• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
template::reset_request_vars must be executed for all requests in the cleanup

this is already happening via "ns_ictl trace freeconn", but we keep

for the time being this as a reminder, when merging with different versions, etc.

don't hardcode /tmp/

    • -4
    • +5
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
simplify file delivery modes

    • -8
    • +6
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
don't start accidentially thread via monitoring

    • -2
    • +2
    ./packages/xotcl-request-monitor/www/index.tcl
improve spelling

replace deprecated function ad_var_type_check_number_p which was used improperly

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

replace deprecated ad_var_type_check_number_p by "string is double -strict "

Mark value checking functions from before ad_page_contract as deprecated

(see also issue #3407)

A 16 years old comment says:

This is some old security crud from before we had ad_page_contract

check_for_form_variable_naughtiness

ad_var_type_check_integer_p

ad_var_type_check_safefilename_p

ad_var_type_check_dirname_p

ad_var_type_check_number_p

ad_var_type_check_word_p

ad_var_type_check_nocheck_p

ad_var_type_check_noquote_p

ad_var_type_check_integerlist_p

    • -12
    • +18
    ./packages/acs-tcl/tcl/utilities-procs.tcl
fix seplling errors

    • -1
    • +1
    ./packages/assessment/www/index-oracle.xql
    • -1
    • +1
    ./packages/assessment/www/index-postgresql.xql
fix spelling errors

whitespace changes

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

fix typos in message catalog and bump version number to force reload

whitespace changes

avoid usage of ad_var_type_check_integer_p

Use a HTML-quote safe idiom to indent categories in the widget

    • -1
    • +1
    ./packages/categories/tcl/widget-procs.tcl
improve documentation and make clear that strong dependency

of request monitor on bgdelivery does not exist anymore

use ns_asynclogfile instead of bgdelivery when available

added ns_asynclogfile to icanuse features

    • -1
    • +10
    ./packages/acs-tcl/tcl/00-canisue-procs.tcl
document optional channel closing during subscribe operations

    • -5
    • +13
    ./packages/acs-subsite/www/shared/ajax/chat.tcl
output warnings when workflow constructs are created shadowing potentially global commands

Make sure connection channel is available (e.g. not detached) before returning content, as more recent Naviserver versions would return an error

    • -2
    • +4
    ./packages/acs-subsite/www/shared/ajax/chat.tcl
Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

    • -2
    • +2
    ./packages/acs-tcl/tcl/tcltrace-procs.tcl
Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

    • -2
    • +2
    ./packages/acs-tcl/tcl/tcltrace-procs.tcl
improve code documentation and honor existing settings

add missing ad_script_abort

    • -1
    • +2
    ./packages/file-storage/www/view/index.vuh
whitespace changes

improve spelling

use same idioms for checking for exising commands

    • -6
    • +6
    ./packages/acs-tcl/tcl/30-xml-utils-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-www-procs.tcl