• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add missing change in the data model from previous commit

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

    • -19
    • +0
    ./packages/acs-subsite/lib/home.xql
    • -16
    • +6
    ./packages/acs-subsite/www/user/portrait/index.tcl
    • -75
    • +15
    ./packages/acs-subsite/www/user/portrait/upload.tcl
    • -38
    • +0
    ./packages/acs-subsite/www/user/portrait/upload.xql
avoid errors, when connection is already closed

fix more spelling issues

remove spurious "expr" in "expr"

    • -2
    • +2
    ./packages/acs-mail-lite/www/doc/imap-test.tcl
simplfy expressions (no need for backslash), standardize writing of RFC

    • -3
    • +4
    ./packages/acs-mail-lite/tcl/utils-procs.tcl
fix spelling

Apply pachtes #960, #961, #962 and #963 from Ben Brink, bump version number to 5.10.0d3 such that changes in .info file get picked up

provide templated error pages for subsite. without this, error pages for host-node-mapped subsites are a pain

CVS: ----------------------------------------------------------------------

    • -2
    • +2
    ./packages/acs-subsite/acs-subsite.info
    • -0
    • +5
    ./packages/acs-subsite/www/shared/403.adp
    • -0
    • +4
    ./packages/acs-subsite/www/shared/404.adp
    • -0
    • +5
    ./packages/acs-subsite/www/shared/500.adp
    • -0
    • +5
    ./packages/acs-subsite/www/shared/503.adp
fix for bug #3338

fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Improve HTML

    • -2
    • +2
    ./packages/acs-mail-lite/www/doc/inbound.adp
modernize Tcl code

prefer ad_try over catch, simplify expression

fix typos

Protect Tcl's file operations against leading dashes in file names

change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

    • -8
    • +48
    ./packages/acs-mail-lite/tcl/bounce-procs.tcl
    • -0
    • +877
    ./packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
  1. … 57 more files in changeset.
Add ad_script_abort (thanks to Felix Moedritscher)

    • -1
    • +2
    ./packages/acs-templating/tcl/list-procs.tcl
    • -1
    • +2
    ./packages/xotcl-core/tcl/30-widget-procs.tcl
Use ad_script_abort after ns_return

Consistently use ad_script_abort after ad_returnredirect

    • -1
    • +5
    ./packages/new-portal/tcl/portal-procs.tcl
Fix bad handler type error, use ad_try/finally instead of else (Thanks to Felix Moedritscher)

    • -2
    • +2
    ./packages/xowiki/tcl/import-procs.tcl
Fixed package version numbering

Added missing index creation statment; Fixed typo in index name

remove obsolete comment (basic hastore support was moved to xowiki)

Make sure to add hkey when db has hstore defined

    • -1
    • +19
    ./packages/xowiki/tcl/xowiki-procs.tcl
Corrected table name

add return_url to to add_url on view-one-day-display

Add custom delimiter to csv (Thanks to Monika Andergassen)

    • -4
    • +6
    ./packages/xotcl-core/tcl/30-widget-procs.tcl
provide more feedback when tdom parsing fails

    • -4
    • +44
    ./packages/acs-tcl/tcl/text-html-procs.tcl