• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix example in documentation and small code cleanup

    • -2
    • +4
    ./acs-templating/www/scripts/xinha/attach-file.tcl
Avoid unnecesary existence checks

Whitespace changes

    • -34
    • +32
    ./rss-support/tcl/rss-support-procs.tcl
Avoid unnecesary existence checks

    • -2
    • +2
    ./rss-support/tcl/rss-support-procs.tcl
Whitespace changes

    • -13
    • +13
    ./acs-automated-testing/tcl/tclwebtest-procs.tcl
Fix wrong bracket

    • -2
    • +2
    ./acs-automated-testing/tcl/tclwebtest-procs.tcl
Avoid unnecesary existence checks

    • -3
    • +3
    ./acs-service-contract/tcl/contract-procs.tcl
align comment to implementation; be more explicit on optional/default values

    • -7
    • +13
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

    • -4
    • +4
    ./acs-content-repository/tcl/content-item-procs.tcl
Whitespace changes

    • -196
    • +195
    ./assessment/tcl/as-assessment-procs.tcl
    • -60
    • +61
    ./assessment/tcl/as-item-display-tb-procs.tcl
    • -92
    • +92
    ./assessment/tcl/as-item-procs.tcl
    • -51
    • +51
    ./assessment/tcl/as-item-type-sa-procs.tcl
Avoid unnecesary existence checks.

    • -1
    • +1
    ./assessment/tcl/as-assessment-procs.tcl
    • -1
    • +1
    ./assessment/tcl/as-item-display-tb-procs.tcl
    • -1
    • +1
    ./assessment/tcl/as-item-type-sa-procs.tcl
Remove duplication and use more api

This code could not work on oracle... not sure if this was considered, or people just assumed fts was a Postgres-only thing

    • -36
    • +14
    ./acs-content-repository/tcl/search-procs.tcl
Whitespace cleanup

    • -71
    • +71
    ./acs-tcl/tcl/navigation-procs.tcl
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

    • -3
    • +3
    ./acs-admin/www/users/complex-search.tcl
Use api to remove difference between oracle and postgres code and replace array with dict idioms

    • -20
    • +0
    ./acs-admin/www/subsites-oracle.xql
    • -20
    • +0
    ./acs-admin/www/subsites-postgresql.xql
Remove leftover xql files

    • -19
    • +0
    ./acs-admin/www/index-postgresql.xql
Use api to remove difference between oracle and postgres codebase

    • -5
    • +14
    ./acs-subsite/www/admin/host-node-map/index.tcl
Reduce divergency between oracle and postgres codebase

    • -22
    • +0
    ./rss-support/www/subscrs-include-oracle.xql
    • -22
    • +0
    ./rss-support/www/subscrs-include-postgresql.xql
    • -1
    • +14
    ./rss-support/www/subscrs-include.tcl
Avoid two times the same query just because we might filter by forum

    • -20
    • +2
    ./forums/lib/search/search-chunk-postgresql.xql
    • -12
    • +10
    ./forums/lib/search/search-chunk.tcl
Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    ./forums/lib/message/content-updater-oracle.xql
    • -8
    • +0
    ./forums/lib/message/content-updater.adp
    • -45
    • +0
    ./forums/lib/message/content-updater.tcl
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
    ./forums/lib/message/thread-chunk-postgresql.xql
    • -19
    • +15
    ./forums/lib/message/thread-chunk.tcl
Use more api to streamline queries and reduce divergency between oracle and postgres codebase

    • -22
    • +4
    ./forums/tcl/messages-procs-oracle.xql
    • -28
    • +6
    ./forums/tcl/messages-procs-postgresql.xql
While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

    • -25
    • +0
    ./file-storage/tcl/file-storage-procs-oracle.xql
    • -43
    • +0
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -61
    • +78
    ./file-storage/tcl/file-storage-procs.tcl
    • -39
    • +13
    ./file-storage/www/folder-delete.tcl
    • -26
    • +17
    ./file-storage/www/version-delete.tcl
Remove leftover sql and unused variables

    • -45
    • +0
    ./calendar-portlet/www/calendar-portlet-oracle.xql
    • -45
    • +0
    ./calendar-portlet/www/calendar-portlet-postgresql.xql
    • -13
    • +5
    ./calendar-portlet/www/calendar-portlet.tcl
Whitespace changes

    • -3
    • +3
    ./file-storage/tcl/file-storage-procs.tcl
new feature: offer swa the ability to view compiled template

    • -7
    • +9
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +3
    ./acs-api-browser/www/content-page-view.adp
    • -6
    • +28
    ./acs-api-browser/www/content-page-view.tcl
Reduce divergency between oracle and postgres codebase and remove redundant statements

    • -43
    • +0
    ./file-storage/www/file-postgresql.xql
Remove leftover statement

    • -2
    • +2
    ./acs-content-repository/tcl/filter-procs.tcl
remove empty, unused, privated function acs_reference_get_db_structure

    • -21
    • +0
    ./acs-reference/tcl/acs-reference-procs.tcl