• last updated 42 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
New CSS abstraction: xowiki::CSS

Before this change, the application developer was responsible to

initialize the CSS-speficic settings (such as setting default values

for parameter classes). The new object xowiki::CSS is initialized

automatically, when an xowiki class (or one of its subclasses) is

initialized. Furthermore, it provides a per-thread caching to reduce

double work. Furthermore, the xowiki::CSS provides a mapping between

abstract and concrete CSS class names, such that switching between

different CSS toolkits becomes easier (e.g. upgrade from bootstrap 3

to newer versions).

xowiki::CSS initialize ;# make sure, everything is in line with PreferredCSSToolkit

xowiki::CSS clear ;# reset the mapping

xowiki::CSS toolkit ;# return the toolkit name

xowiki::CSS class /classname/ ;# perform CSS class name mapping

The methods "setCSSDefaults" and "preferredCSSToolkit" as deprecated.

The version number was bumped to 5.10.0d81

  1. … 2 more files in changeset.
improved code comments

more cleanup for setting of potentially unencoded return_url

streamline returnredirect commands

make sure, the provided URL is always properly encoded

prefer variable resolver over method calls for unset

minor refactoring to correct old-style widgetSpecs; prefer variable resolver over method calls for unset

support editor=none in arbitrary form-field specs

prefer usage of "xo::write_tmp_file" over "xo::write_file" for writing tmp files

  1. … 1 more file in changeset.
Do not urlencode the return URL in every case, but only when this falls back to the current URL from the connection context, normally coming from "ns_conn url" which will return it "raw", as in not encoded for any purpose

URLencode the return URL, or the server might complain for invalid characters (e.g. unencoded umlaut characters)

Remove hard-coded styling with the "style" element to get a more consistent appearance

(many thanks to Monika Andergassen for looking into this).

  1. … 2 more files in changeset.
improve query variable checking

fix creating/editing of xowiki::Forms

This change essentially reverts the change of July 2, which broke

the feature to specify "editor=none". This is important for the

"form" form-field entry, which requires a FORM tag, that is

usually removed by actual version of the ckeditor.

added value checker, improved comments and logging statements

upgrade default ckeditor from 4.15.1 to 4.16.1 (released in May 2021)

  1. … 2 more files in changeset.
Upgrade to jQuery 3.6.0 (released March 2021)

  1. … 9 more files in changeset.
parameterize xowiki::test::edit_form_page with -next_page_must_contain

This changes supports more flexible checking of expected content on page after editing.

Default is backwards compatible

  1. … 1 more file in changeset.
In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized

This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass.

make child_components a proc (::xowiki::formfield::child_components) and add filter expression

Added new method "child_components": Return for a list of form-field objs all child components

added test case for form field validation

improve spelling

make comments more uniform

provide a less confusing name for new methodm improve comments

Fix typo in comment

Implement reset_to_default method to reset formfields in case of validation error

the current behavior of this method is currently a no-op for every formfield, except files, where we want to make sure the value has been reset. We also handle the case now of compound fields, as they might be compounds of file formfields

Add all whitespace characters between double quotes when converting a dict to hstore

Many thanks to Guenter Ernst for the analysis.

Extended regression test

Fix typo

adapt personal-notification interface to support bulk messaging

    • -13
    • +26
    ./personal-notification-procs.tcl
strengthen parameter checking

  1. … 3 more files in changeset.