Activity OpenACS/openacs-4/packages/xowiki/tcl

8:46 pm

gustafn

whitespace changes

- -38
- +56
./notification-procs.tcl
- History
- Source
- Diff
./notification-procs.tcl
- -3
- +5
./xowiki-init.tcl
- History
- Source
- Diff
./xowiki-init.tcl
- -4
- +7
./xowiki-mode-procs.tcl
- History
- Source
- Diff
./xowiki-mode-procs.tcl
- -2
- +2
./test/test-procs.tcl
- History
- Source
- Diff
./test/test-procs.tcl
- -21
- +21
./upgrade/upgrade.tcl
- History
- Source
- Diff
./upgrade/upgrade.tcl
… 7 more files in changeset.

8:34 pm

gustafn

make "instantiate_forms" a method of packages

this reads better than the previous variant based on the Weblog class.

- -7
- +6
./folder-procs.tcl
- History
- Source
- Diff
./folder-procs.tcl
- -9
- +8
./form-field-procs.tcl
- History
- Source
- Diff
./form-field-procs.tcl
- -5
- +4
./import-procs.tcl
- History
- Source
- Diff
./import-procs.tcl
- -14
- +13
./includelet-procs.tcl
- History
- Source
- Diff
./includelet-procs.tcl
- -5
- +4
./package-procs.tcl
- History
- Source
- Diff
./package-procs.tcl
- -3
- +1
./syndicate-procs.tcl
- History
- Source
- Diff
./syndicate-procs.tcl
- -26
- +8
./weblog-procs.tcl
- History
- Source
- Diff
./weblog-procs.tcl
- -2
- +2
./xowiki-procs.tcl
- History
- Source
- Diff
./xowiki-procs.tcl
- -7
- +7
./xowiki-uploader-procs.tcl
- History
- Source
- Diff
./xowiki-uploader-procs.tcl
- -3
- +3
./xowiki-utility-procs.tcl
- History
- Source
- Diff
./xowiki-utility-procs.tcl
- -4
- +15
./test/test-procs.tcl
- History
- Source
- Diff
./test/test-procs.tcl
- -3
- +5
./test/xowiki-link-test-procs.tcl
- History
- Source
- Diff
./test/xowiki-link-test-procs.tcl
… 3 more files in changeset.

8:33 pm

gustafn

whitespace changes

- -6
- +6
./category-procs.tcl
- History
- Source
- Diff
./category-procs.tcl
- -7
- +7
./menu-procs.tcl
- History
- Source
- Diff
./menu-procs.tcl
- -9
- +9
./xowiki-callback-procs.tcl
- History
- Source
- Diff
./xowiki-callback-procs.tcl

1:16 pm

gustafn

MenuBar reform

- MenuBars are now easier programmatically extensible (easier to maintain)

- refactored code, reduced scatted definitions (all configurations

at the same place)

- unified templating:

use body property @body.folderHTML@ instead of @folderhtml@

From the former API calls only "update_items" has changed,

all existing configurations (i.e. via folders or package parameter)

should continue to work.

== Changes:

One can now extend menubars via menu entry definition

{config -use YOURCONFIG -class YOURCLASS}

in two directions:

a) subclassing

define your own menubar class YOURCLASS, which should

be a subclass of ::xowiki::MenuBar

b) provide your own configuration method to provide

a more tailored configuration. This is performed

by defining a method "config=YOURCONFIG" for ::xowiki::MenuBar

The latter method is used for test-items, which can define a

test item folder by using

-- extra_menu_entries ---

{config -use test-items}

instead of

-- extra_menu_entries ---

{entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text}

{entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText}

{entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC}

{entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC}

{entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder}

{entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload}

{entry -name New.App.OnlineExam -form en:online-exam.wf}

{entry -name New.App.InclassQuiz -form en:inclass-quiz.wf}

{entry -name New.App.InclassExam -form en:inclass-exam.wf}

See below for the definition of the "test-items" configuration method,

which is based on the default definitions. In general, the definition

in this method can be performed via menu-entries (same syntax as in

other menu entries) or via the MenuBar API (e.g. calling

":add_menu_item ...").

All configurations follow the following definition order

where later entries can refine earlier entries:

- package level: package parameter ExtraMenuEntries

- configuration method: use standard or tailored confguration methods

- per-folder definition: content of the extra_menu_entries

Note that the menu entry definition language supports as well

adding/clearing menus, etc., so almost everything can be refined.

I've noticed that the tlf* code has several scattered menu

definitions, which are as well done in every case differently.

By these definition one can define e.g. a learning-app folder (where

"New" can be used to define new app folders), and the app folders can

provide their own "New" entries, e.g. for clickers and

others. E.g. For "clickers" there is already on non-oo definition to

achieve similar things (which should be altered to the new method),

but on other places, there are some hard-coded definitions for root

folders, etc. The menubars of the learning-apps should be made this

way more consistent with the rest (e.g. using "New", supporting "table

of contents" for clipboard interactions, etc.)

namespace eval ::xowiki {

::xowiki::MenuBar instproc config=test-items {

{-bind_vars {}}

-current_page:required

-package_id:required

-folder_link:required

-return_url

} {

:config=default \

-bind_vars $bind_vars \

-current_page $current_page \

-package_id $package_id \

-folder_link $folder_link \

-return_url $return_url

return {

{clear_menu -menu New}

{entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text}

{entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText}

{entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC}

{entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC}

{entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder}

{entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload}

{entry -name New.App.OnlineExam -form en:online-exam.wf}

{entry -name New.App.InclassQuiz -form en:inclass-quiz.wf}

{entry -name New.App.InclassExam -form en:inclass-exam.wf}

}

- -6
- +6
./adp-generator-procs.tcl
- History
- Source
- Diff
./adp-generator-procs.tcl
- -137
- +122
./folder-procs.tcl
- History
- Source
- Diff
./folder-procs.tcl
- -85
- +268
./menu-procs.tcl
- History
- Source
- Diff
./menu-procs.tcl
- -62
- +22
./xowiki-www-procs.tcl
- History
- Source
- Diff
./xowiki-www-procs.tcl
… 13 more files in changeset.

1:50 am

gustafn

improve comments

- -1
- +1
./table-widget-procs.tcl
- History
- Source
- Diff
./table-widget-procs.tcl
- -3
- +5
./xowiki-www-procs.tcl
- History
- Source
- Diff
./xowiki-www-procs.tcl
… 3 more files in changeset.

1:33 am

gustafn

reduce usage of anonymous arrays

- -21
- +13
./menu-procs.tcl
- History
- Source
- Diff
./menu-procs.tcl

1:56 pm

gustafn

accept as page_ref for an object as well an item_id

This change simplify resolving items. raw ids seem

fine, since the listing are not persisted or moved between

OpenACS instances.

- -1
- +2
./folder-procs.tcl
- History
- Source
- Diff
./folder-procs.tcl
- -8
- +16
./xowiki-www-procs.tcl
- History
- Source
- Diff
./xowiki-www-procs.tcl

1:02 pm

gustafn

fix broken variable reference (pg changed?)

- -2
- +2
./includelet-procs.tcl
- History
- Source
- Diff
./includelet-procs.tcl

7:03 pm

gustafn

Use full URL paths for bulk actions.

This change allows one to mark items from multiple child-resources

displayed on one page and add these to the clipboard. Use the same

logic for bluk-delete and bulk adding to the clipboard.

- -2
- +4
./folder-procs.tcl
- History
- Source
- Diff
./folder-procs.tcl
- -10
- +18
./package-procs.tcl
- History
- Source
- Diff
./package-procs.tcl
- -62
- +58
./xowiki-www-procs.tcl
- History
- Source
- Diff
./xowiki-www-procs.tcl

4:14 pm

gustafn

replace array by dict

- -14
- +18
./form-field-procs.tcl
- History
- Source
- Diff
./form-field-procs.tcl
- -6
- +6
./includelet-procs.tcl
- History
- Source
- Diff
./includelet-procs.tcl

4:11 pm

gustafn

www-clipboard-add: allow object to be fully qualified

old conventions continue to work

- -5
- +34
./xowiki-www-procs.tcl
- History
- Source
- Diff
./xowiki-www-procs.tcl

10:53 am

gustafn

avoid warning for "hidden" table widget columns, used e.g. for sorting

- -0
- +5
./table-widget-procs.tcl
- History
- Source
- Diff
./table-widget-procs.tcl

7:16 pm

Make :folder_id available as a package instance variable immediately, in a way that if the folder instantiation needs e.g. to fetch a parameter, the folder_id will be there to determine the right parameter page, which otherwise would be looked up e.g. in the site-wide pages and cached with wrong values for the cache lifetime

- -4
- +3
./package-procs.tcl
- History
- Source
- Diff
./package-procs.tcl

6:53 pm

antoniop

Make ::xowiki::Package default_locale react to changes in the connection locale by caching only when the parameter use_connection_locale is not set, use ::xowiki::Package default_locale result instead of always the connection locale to determine nls_language for new Pages and FormPages, so that default language for a particular xowiki instance is decided by use_connection_locale parameter