• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Check permissions when one accesses the script and also when one performs the actual unsubscribing operation

Harden safety: require login, do not let people outside the requester fiddle with the frequency

reduce public footprint

mark private functions as private

  1. … 9 more files in changeset.
make clear from the user-interface that admin is managing the notifications of someone else

Remove colon that gets confused as a bind variable

Add missing semicolon

Solve a potential issue when one would cleanup "dynamic" notification requests: this was done directly on the table and could therefore leave dangling acs_objects around

- cleanup all acs_objects of type 'notification_request' that do not have a corresponding entry in the table (~35000 downstream)

- embed logic of delete_dynamic_requests query inside select_invalid_request_ids query, as there the deletion is done properly

file upgrade-5.10.0d6-5.10.0d7.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
Rewrite idiom to be portable (limit is psql only)

    • -10
    • +0
    ./tcl/notification-callback-procs.xql
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 18 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 9 more files in changeset.
fix an at lease 11 year old bug... not sure, why this was not discovered earlier

Whitespace cleanup

use dot instead of colon as separator between package name and cache key to ease readability

  1. … 10 more files in changeset.
acs::per_thread_cache: standardize per-thread caching

- added per-thread cache based on namespaced Tcl variables.

- use per-thread-cache on several occasions

- bump version number of acs-tcl to 5.10.0d34

  1. … 13 more files in changeset.
Provide an include flag to hide the list of subscribers

Provide a css class hook to customize styling according to notification type

Added index on foreign key columns

    • -2
    • +3
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +5
    ./sql/oracle/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
file upgrade-5.10.0d4-5.10.0d5.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

  1. … 11 more files in changeset.
Replace parse_incoming_email with ad_parse_incoming_email, replace occurrences

  1. … 1 more file in changeset.
Use already existing message-key.

Reduce divergency between oracle and postgres

  1. … 3 more files in changeset.
improve spelling

  1. … 14 more files in changeset.
improve spelling

  1. … 10 more files in changeset.
Reduce divergency between oracle and postgres codebase

Add ad_page_contract to pages (fixes automated tests)

Bring files on oacs-5-10 in sync with HEAD

    • -0
    • +2
    ./catalog/notifications.it_IT.ISO-8859-1.xml
  1. … 15 more files in changeset.
Update italian localization

    • -0
    • +2
    ./catalog/notifications.it_IT.ISO-8859-1.xml