OpenACS / openacs-4 / packages / notifications / tcl

sweep-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 23 Apr
Commits this week: 0
Total Lines of Code (LoC): 185
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Feb 2022
2:19 pm

gustafn

Fixes for Oracle 19c: make query portable to Oracle by replacing USING by explicit ON joins

This fixed the following problem, where the problem is not easy to spot on first sight:

[16/Feb/2022:13:26:09][12845.7efd2d3e1700][-sched:0:41:22-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00904: "NOTIFICATION_REQUESTS"."USER_ID": invalid identifier

: SQL:

: select notification_id,

: notif_subject,

: notif_text,

: notif_html,

: file_ids,

: user_id,

: request_id,

: type_id,

: delivery_method_id,

: response_id,

: notif_date,

: notif_user,

: acs_permission.permission_p(notification_requests.object_id, !>>>!notification_requests.user_id, 'read') as still_valid_p

: from notifications inner join notification_requests using (type_id, object_id)

: inner join acs_objects on (notification_requests.request_id = acs_objects.object_id)

: left outer join notification_user_map using (notification_id, user_id)

: where sent_date is null

: and creation_date <= notif_date

: and (notif_date is null or notif_date < current_timestamp)

: and interval_id = :interval_id

Options
    • -7
    • +10
    ./sweep-procs.tcl
Tuesday 17 Aug 2021
11:54 am

gustafn

Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

Options
    • -18
    • +54
    ./sweep-procs.tcl
Saturday 06 Mar 2021
8:36 pm

gustafn

reduce public footprint

Options
    • -3
    • +3
    ./sweep-procs.tcl
  2. … 3 more files in changeset.
Monday 09 Nov 2020
6:38 pm

antoniop

Remove colon that gets confused as a bind variable

Options
    • -2
    • +2
    ./sweep-procs.tcl
Friday 06 Nov 2020
4:51 pm

antoniop

Solve a potential issue when one would cleanup "dynamic" notification requests: this was done directly on the table and could therefore leave dangling acs_objects around

- cleanup all acs_objects of type 'notification_request' that do not have a corresponding entry in the table (~35000 downstream)

- embed logic of delete_dynamic_requests query inside select_invalid_request_ids query, as there the deletion is done properly

Options
    • -6
    • +14
    ./sweep-procs.tcl
  2. … 3 more files in changeset.
Friday 15 Mar 2019
5:48 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -3
    • +28
    ./sweep-procs.tcl
  2. … 2 more files in changeset.
Monday 07 May 2018
4:55 pm

hectorr

Replace 'linsert' with 'lappend'

Options
    • -2
    • +2
    ./sweep-procs.tcl
4:46 pm

hectorr

Fix linsert command argument expansion + Whitespace

Options
    • -31
    • +30
    ./sweep-procs.tcl
Tuesday 01 May 2018
11:06 am

gustafn

improve list operations

Options
    • -2
    • +2
    ./sweep-procs.tcl
  2. … 5 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -1
    • +7
    ./sweep-procs.tcl
  2. … 7834 more files in changeset.
Saturday 12 Sep 2015
1:06 pm

gustafn

- add editor hints to keep spaces/tabs in the future more consistent

Options
    • -1
    • +7
    ./sweep-procs.tcl
  2. … 350 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -7
    • +7
    ./sweep-procs.tcl
  2. … 2547 more files in changeset.
Tuesday 27 Aug 2013
2:20 pm

gustafn

- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

Options
    • -7
    • +7
    ./sweep-procs.tcl
  2. … 42 more files in changeset.
Wednesday 31 Mar 2010
10:35 pm

michaels

part 2 of (temp) fix - added bit to sweeper that clears out invalid (unauthorized) notif requests

Options
    • -1
    • +6
    ./sweep-procs.tcl
  2. … 1 more file in changeset.
Wednesday 27 Jun 2007
8:54 pm

matthewg

Adding support for file attachments via file_ids in the notifications table, includes sql upgrade scripts and bumps the version to 5.4.0d3

Options
    • -1
    • +7
    ./sweep-procs.tcl
  2. … 10 more files in changeset.
Saturday 26 Feb 2005
6:52 pm

jeffd

removed the remaining procs which were -deprecated -warn in 5.0 and fixed most occurances of those procs in the code

Options
    • -7
    • +1
    ./sweep-procs.tcl
  2. … 43 more files in changeset.
Thursday 13 Jan 2005
2:54 pm

jeffd

commit to HEAD of merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040724 and jcd-merge-5-1-20050111

Options
    • -3
    • +3
    ./sweep-procs.tcl
  2. … 2275 more files in changeset.
Monday 15 Nov 2004
9:48 pm

jader

More robust parameters, added -- to ad_html_text_convert

Options
    • -3
    • +3
    ./sweep-procs.tcl
Saturday 24 Jul 2004
10:33 am

jeffd

merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040712 and jcd-merge-5-1-20040724 to HEAD

Options
    • -13
    • +6
    ./sweep-procs.tcl
  2. … 138 more files in changeset.
Wednesday 14 Jul 2004
10:42 pm

andrewg

Removed extraneous linebreaks. Removed a redundant lappend to list_of_notification_ids.

Options
    • -13
    • +6
    ./sweep-procs.tcl
Tuesday 29 Jun 2004
12:17 pm

jeffd

merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040517 and jcd-merge-5-1-20040628 to HEAD

Options
    • -7
    • +41
    ./sweep-procs.tcl
  2. … 687 more files in changeset.
Thursday 24 Jun 2004
9:27 pm

janine

fix from Sloan: allow HTML notifications. html part is optional so existing calls will still work.

Options
    • -7
    • +41
    ./sweep-procs.tcl
  2. … 8 more files in changeset.
Thursday 16 Oct 2003
4:06 pm

joela

changed more log Notices to Debugs

Options
    • -3
    • +3
    ./sweep-procs.tcl
  2. … 1 more file in changeset.
Wednesday 24 Sep 2003
12:00 am

lars

Fixed bug #418: Batched notifications don't work on some mail browsers

Options
    • -2
    • +2
    ./sweep-procs.tcl
Thursday 28 Aug 2003
11:41 am

lars

Merged 4.6.4d1 (unreleased) to HEAD. This marks the end of the life of the oacs-4-6 branch.

Options
    • -7
    • +8
    ./sweep-procs.tcl
  2. … 816 more files in changeset.
Thursday 12 Jun 2003
3:34 pm

lars

Added support for notifications going out as the user who sent the notification. This required changing the delivery method service contract, so I moved all service contracts into tcl

Options
    • -6
    • +7
    ./sweep-procs.tcl
  2. … 27 more files in changeset.
Saturday 17 May 2003
12:47 pm

jeffd

merge of 4.6.3b1 to HEAD

Options
    • -1
    • +1
    ./sweep-procs.tcl
  2. … 41 more files in changeset.
Wednesday 05 Mar 2003
4:02 pm

lars

Upgrade to 4.6.2: Notifications extensions - dynamic notifications recipients.

Options
    • -6
    • +14
    ./sweep-procs.tcl
  2. … 20 more files in changeset.
Tuesday 25 Feb 2003
11:05 am

lars

Added support for dynamic notifications

Options
    • -5
    • +11
    ./sweep-procs.tcl
  2. … 32 more files in changeset.
Thursday 16 Jan 2003
2:48 pm

jeffd

Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

Options
    • -9
    • +10
    ./sweep-procs.tcl
  2. … 56 more files in changeset.