• last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fixes for Oracle 19c: make query portable to Oracle by replacing USING by explicit ON joins

This fixed the following problem, where the problem is not easy to spot on first sight:

[16/Feb/2022:13:26:09][12845.7efd2d3e1700][-sched:0:41:22-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00904: "NOTIFICATION_REQUESTS"."USER_ID": invalid identifier

: SQL:

: select notification_id,

: notif_subject,

: notif_text,

: notif_html,

: file_ids,

: user_id,

: request_id,

: type_id,

: delivery_method_id,

: response_id,

: notif_date,

: notif_user,

: acs_permission.permission_p(notification_requests.object_id, !>>>!notification_requests.user_id, 'read') as still_valid_p

: from notifications inner join notification_requests using (type_id, object_id)

: inner join acs_objects on (notification_requests.request_id = acs_objects.object_id)

: left outer join notification_user_map using (notification_id, user_id)

: where sent_date is null

: and creation_date <= notif_date

: and (notif_date is null or notif_date < current_timestamp)

: and interval_id = :interval_id

Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

reduce public footprint

  1. … 3 more files in changeset.
Remove colon that gets confused as a bind variable

Solve a potential issue when one would cleanup "dynamic" notification requests: this was done directly on the table and could therefore leave dangling acs_objects around

- cleanup all acs_objects of type 'notification_request' that do not have a corresponding entry in the table (~35000 downstream)

- embed logic of delete_dynamic_requests query inside select_invalid_request_ids query, as there the deletion is done properly

  1. … 3 more files in changeset.
Reduce divergency between oracle and postgres codebase

  1. … 2 more files in changeset.
Replace 'linsert' with 'lappend'

Fix linsert command argument expansion + Whitespace

improve list operations

  1. … 5 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

  1. … 42 more files in changeset.
part 2 of (temp) fix - added bit to sweeper that clears out invalid (unauthorized) notif requests

  1. … 1 more file in changeset.
Adding support for file attachments via file_ids in the notifications table, includes sql upgrade scripts and bumps the version to 5.4.0d3

  1. … 10 more files in changeset.
removed the remaining procs which were -deprecated -warn in 5.0 and fixed most occurances of those procs in the code

  1. … 43 more files in changeset.
commit to HEAD of merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040724 and jcd-merge-5-1-20050111

  1. … 2275 more files in changeset.
More robust parameters, added -- to ad_html_text_convert

merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040712 and jcd-merge-5-1-20040724 to HEAD

  1. … 138 more files in changeset.
Removed extraneous linebreaks. Removed a redundant lappend to list_of_notification_ids.

merge of changes on oacs-5-1 branch between tags jcd-merge-5-1-20040517 and jcd-merge-5-1-20040628 to HEAD

  1. … 687 more files in changeset.
fix from Sloan: allow HTML notifications. html part is optional so existing calls will still work.

  1. … 8 more files in changeset.
changed more log Notices to Debugs

  1. … 1 more file in changeset.
Fixed bug #418: Batched notifications don't work on some mail browsers

Merged 4.6.4d1 (unreleased) to HEAD. This marks the end of the life of the oacs-4-6 branch.

  1. … 816 more files in changeset.
Added support for notifications going out as the user who sent the notification. This required changing the delivery method service contract, so I moved all service contracts into tcl

  1. … 27 more files in changeset.
merge of 4.6.3b1 to HEAD

  1. … 41 more files in changeset.
Upgrade to 4.6.2: Notifications extensions - dynamic notifications recipients.

  1. … 20 more files in changeset.
Added support for dynamic notifications

  1. … 32 more files in changeset.
Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 56 more files in changeset.