• last updated 57 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reimplement the add/edit api to use ad_form

file comment-add-edit.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/comment-add-edit.adp
file comment-edit.adp was initially added on branch oacs-5-10.

file comment-add.adp was initially added on branch oacs-5-10.

file comment-add-edit.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/comment-add-edit.tcl
Cleanup trivial remarks, provide the user_id explictly to the permission check

Fix typo

Enforce the mimetype the same in follow up script

Enforce only valid mime types

set arguments to type integer to avoid strange variable names

Fixes for Oracle 19c: boolean and blob handling

The original SQL query contained boolean values, and did not handle

blobs, which are used int the Oracle data model for the content

fields.

    • -11
    • +11
    ./tcl/general-comments-procs.tcl
fix release dates in .info files

  1. … 82 more files in changeset.
release work

  1. … 204 more files in changeset.
regenerated documentation

  1. … 465 more files in changeset.
bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

  1. … 87 more files in changeset.
remove dependency of general-comments on acs-mail-lite

  1. … 2 more files in changeset.
complete listing of covered procs in test cases

  1. … 14 more files in changeset.
improve spelling

Provide a public general-comments solution to empty messages from a specific package: other xowiki-like packages downstream would otherwise need to call a xowiki private api

  1. … 1 more file in changeset.
Whitespace cleanup

    • -24
    • +24
    ./tcl/general-comments-procs.tcl
use bind variables instead of tcl variable substition in xql fullqueries

  1. … 15 more files in changeset.
Complete api coverage for general-comments

    • -1
    • +111
    ./tcl/test/general-comments-procs.tcl
Cover some more api

Start testing general comments

    • -0
    • +39
    ./tcl/test/general-comments-procs.tcl
file general-comments-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/general-comments-procs.tcl
use consistently the same prefix "general_comments" (and not singular version)

    • -2
    • +2
    ./tcl/general-comments-procs-oracle.xql
    • -2
    • +2
    ./tcl/general-comments-procs-postgresql.xql
improve spelling

  1. … 2 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
Prettify data size using 'util::content_size_pretty'

  1. … 1 more file in changeset.
Fix typo