forums-callback-procs.tcl

  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

  1. … 1 more file in changeset.
Fix typo

Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

  1. … 3 more files in changeset.
make end of options explicit

  1. … 17 more files in changeset.
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 18 more files in changeset.
Reduce divergency between oracle and postgres codebase

  1. … 2 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Replace ad_decode idiom

  1. … 3 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Whitespace changes + editor hints

  1. … 19 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

    • -155
    • +111
    ./forums-callback-procs.tcl
unify spelling of URL

  1. … 3 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- reduce dependencies on acs_object_party_privilege_map

.xql-file reform of forums

- remove sql statements from the code, where these are provided via .xql

- prefer empty sql statements over various forms of *SQL*

- remove obsolete queries

  1. … 6 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- fix api-doc variable @creation-date

- fix invalid @param declaration for API browser

  1. … 4 more files in changeset.
- commit speedup from OpenACS.org, which might be useful for most sites.

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
- normalize string expressions

  1. … 23 more files in changeset.
Added callback implementation of forums_forum for search. Added comment in the SC implementation saying it's deprecated and not used, will have to be removed in 5.5

  1. … 2 more files in changeset.
Merged changes to HEAD ...

  1. … 1556 more files in changeset.
Should be debug, not debig

Added Mannheim's changes which includes allowing of screen name rather than

real name (privacy, parameterized), changes some hard-wired english to message

resource keys, etc.

  1. … 27 more files in changeset.
Fixing typo

First shot at merging oacs-5-2 apps used in .LRN to HEAD.

  1. … 2478 more files in changeset.
Initial import of forums version 1.2.0d4

  1. … 270 more files in changeset.
File improved to implement the application-track callbacks