• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
encode folder_path

Remove commented leftover debugging statement, add comment about why we need to name the list by folder_id

Put template::list name back as parametric, because this code might be included multiple times

  1. … 3 more files in changeset.
Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

  1. … 3 more files in changeset.
Trim whitespaces

Remove unnecessary parentheses and idioms, state query variables explicitly

Dont even offer to delete the root folder as this is prevented anyway

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

  1. … 5 more files in changeset.
Use a lazy but feasible check to decide if we have buttons for copy in the file storage

  1. … 1 more file in changeset.
Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

  1. … 1 more file in changeset.
Add move and copy buttons only when available folders for these actions exist

  1. … 1 more file in changeset.
Hide file-storage actions that are not allowed for the user. (receives analogous modifications on Learn@WU)

  1. … 1 more file in changeset.
- tighten page contracts

  1. … 4 more files in changeset.
- remove dead code: form n_past_days_form is nowhere used, probably some legacy

  1. … 2 more files in changeset.
- provide image dimensions

  1. … 2 more files in changeset.
- remove useless parenthesis

- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- change spelling of TCL to Tcl

- change requirements to Tcl 8.5

  1. … 64 more files in changeset.
- add new utility-function for en/decoding the "path" part using the url-encding scheme as define in RFC 3986. The functions are defined as stubs for backward compatibility for aolserver, since aolserver uses always the same encoding

- use ad_urlencode_path in file-storage where necessary

- some cleanup

  1. … 1 more file in changeset.
- new style string expressions

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch

- bump version number

  1. … 23 more files in changeset.
Encode files URL properly (would fail if the filename had a plus sign, sharp one etc in it)

  1. … 3 more files in changeset.
Untabify and indent

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
Fix: Specifying the package_id when getting the BehaveLikeFileSystemP parameter.

The size of a URL is returned as "", resulting in its being displayed as

"bytes" with no number in front. Changed it to simply display the empty

string for the size of a URL.

Increase contrast between fg and bg for the filename