OpenACS / openacs-4 / packages / file-storage / www

file-add.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 20
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 349
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 25 Feb
6:29 pm

gustafn

Improved consistency with external programs

Since "unzip" is used as well on various other places,

use it as well in the file storage. This means that

the parameter "UnzipBinary" for the file-storage package

is now obsolete.

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 1 more file in changeset.
Sunday 22 Oct 2023
6:30 pm

gustafn

strengthen boolean parameters in page contracts

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 31 more files in changeset.
Friday 27 Jan 2023
12:59 pm

gernst

Improve validation

Options
    • -1
    • +3
    ./file-add.tcl
  2. … 1 more file in changeset.
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./file-add.tcl
  2. … 6 more files in changeset.
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -1
    • +5
    ./file-add.tcl
  2. … 2 more files in changeset.
Friday 18 Feb 2022
1:56 pm

gustafn

Make use of util::file_content_check and check also in other cases

This change also covers the case, where the checkmark for uploading

zip files was added marked in "upload file". It will also report

errors which were silently swalled before.

Bumped version number to 5.10.1d1

Options
    • -3
    • +17
    ./file-add.tcl
  2. … 2 more files in changeset.
Wednesday 29 Dec 2021
6:38 pm

antoniop

Similar to the folder-create script, complain if the filename turns out empty after sanitizing

Options
    • -1
    • +9
    ./file-add.tcl
Monday 07 Jun 2021
4:00 pm

antoniop

Port sanitizing of upload file name from downstream

Options
    • -1
    • +8
    ./file-add.tcl
Wednesday 31 Mar 2021
1:32 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 5 more files in changeset.
Tuesday 21 Jul 2020
4:06 pm

gustafn

use "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -5
    • +5
    ./file-add.tcl
  2. … 12 more files in changeset.
Friday 07 Dec 2018
1:02 pm

antoniop

Localize file-size limits in the UI

Options
    • -4
    • +5
    ./file-add.tcl
12:54 pm

antoniop

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Options
    • -2
    • +20
    ./file-add.tcl
12:34 pm

antoniop

Prettify code

Options
    • -10
    • +20
    ./file-add.tcl
1:02 am

antoniop

Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

Options
    • -48
    • +26
    ./file-add.tcl
Thursday 06 Dec 2018
4:48 pm

antoniop

File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 6 more files in changeset.
Monday 17 Sep 2018
4:23 pm

hectorr

Whitespace changes

Options
    • -102
    • +101
    ./file-add.tcl
  2. … 3 more files in changeset.
Saturday 07 Apr 2018
9:13 pm

gustafn

remove conditions, which are always true

remove parens

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 2 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -46
    • +86
    ./file-add.tcl
  2. … 7834 more files in changeset.
Monday 27 Mar 2017
12:44 pm

gustafn

Improve robustness of "file delete" operations

Options
    • -3
    • +3
    ./file-add.tcl
  2. … 19 more files in changeset.
Sunday 27 Nov 2016
1:19 pm

gustafn

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 15 more files in changeset.
Saturday 01 Oct 2016
1:04 pm

gustafn

- use confirm handler instead of "onclick=..." in all packages in oacs-5-9

Options
    • -2
    • +1
    ./file-add.tcl
  2. … 15 more files in changeset.
Tuesday 27 Sep 2016
12:42 pm

gustafn

- use event listener instead of onclick handler

- hint based on "fs_title_msg" is probably not shown since many years.

Options
    • -13
    • +43
    ./file-add.tcl
  2. … 1 more file in changeset.
Friday 20 May 2016
10:37 pm

gustafn

- bump version number to 5.9.1d1

- improve security of page_contracts

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 8 more files in changeset.
Sunday 08 May 2016
12:19 pm

gustafn

- handle case, where neither file_id nor folder_id is specified

Options
    • -2
    • +2
    ./file-add.tcl
Saturday 02 Jan 2016
9:13 pm

gustafn

.xql-file reform of file-storage

Options
    • -31
    • +36
    ./file-add.tcl
  2. … 18 more files in changeset.
Saturday 12 Sep 2015
1:06 pm

gustafn

- add editor hints to keep spaces/tabs in the future more consistent

Options
    • -1
    • +7
    ./file-add.tcl
  2. … 350 more files in changeset.
Saturday 27 Jun 2015
11:41 pm

gustafn

- standardize url construction to protect against injection attacks

- hardening page contracts

Options
    • -4
    • +4
    ./file-add.tcl
  2. … 8 more files in changeset.
Friday 12 Jun 2015
10:45 am

gustafn

- use type checking for boolean parameters in page_contracts to improve security

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 14 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -22
    • +26
    ./file-add.tcl
  2. … 2547 more files in changeset.
Thursday 23 Oct 2014
9:21 am

gustafn

- fix for bug #3234

this adresses as well issue #731

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 2 more files in changeset.