• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Prefer 'person::name' to 'acs_user::get_element ... -name' + Fix arguments: user_id -> person_id

  1. … 6 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 2 more files in changeset.
Recommend and use 'person::name' instead of 'acs_user::get_element ... -name' in deprecated proc

Add missing referer var

permission check reform (part 1): provide API for permission cache

    • -3
    • +5
    ./www/admin/site-wide-admin-toggle.tcl
  1. … 12 more files in changeset.
Remove leftover call to dotlrn_community::type_exists

fix non-existing call to dotlrn_community::type_exists

Remove duplicated queries and logic, simplify idioms

    • -168
    • +5
    ./www/communities-chunk-oracle.xql
    • -188
    • +6
    ./www/communities-chunk-postgresql.xql
Reduce divergencies between oracle and postgres codebase

Don't pass fine tcl variables through the query, avoid unnecessary quoting (bulk-mail api would pass variable to the stored procedure using ':' notation)

Reduce divergencies between oracle and postgres codebase

Remove unneded dict creation

  1. … 1 more file in changeset.
Reduce code duplication, exploit API when retrieving user info

Reduce divergencies between oracle and postgres codebase

    • -58
    • +0
    ./www/admin/archived-communities-oracle.xql
    • -58
    • +0
    ./www/admin/archived-communities-postgresql.xql
    • -6
    • +54
    ./www/admin/archived-communities.tcl
unify spelling of names

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 471 more files in changeset.
remove duplicated words

  1. … 5 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 200 more files in changeset.
Fix one more recently introduced bug detected by Hani Gadllah.

remove conditions, which are always true

remove parens

simplify code and make it more consistent

  1. … 2 more files in changeset.
stop using deprecated procs (site_node_delete_package_instance, site_node_id)

modernize Tcl

use per-thread caching for dotlrn_community::get_community_id to reduce stress on util_memoize cache

bump versions of packages with DotLRN style version numbering to HEAD numbers (2.10.0*)

  1. … 35 more files in changeset.
Fix typos

  1. … 16 more files in changeset.
Fix typos

  1. … 61 more files in changeset.
Fix typos related to dotlrn naming

  1. … 1 more file in changeset.
fix typos

  1. … 10 more files in changeset.