• last updated 43 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Streamline and optimize idiom

Declare explicitly the only column we need in a way that DBMS can create a better query plan

Introduce a callback hook for packages to insert some specific logic

Driver is reduce difference between downstream and upstream code

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7820 more files in changeset.
Standardize spellings of names

  1. … 11 more files in changeset.
Removed duplicated statement unarchive.update_archive_p

Simplified conditional expression

Fix spelling errors

  1. … 46 more files in changeset.
Use "ad_abort_script" in dotlrn::do_abort instead of plain tcl error to reduce log-spamming

- replace deprecated "cc_email_from_party ..." by "party::email -party_id ..."

- get_community_id: pass current url to closest_ancestor_package if no

package_id is given

- use list for argument of util_memoize to avoid surprises

- don't write HTML tags to error.log

  1. … 1 more file in changeset.
- prefer sql statements between curly braces

  1. … 5 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 20 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 203 more files in changeset.
Dotlrn-changes:

* make theme-zen a regular openacs-subsite theme

  1. … 7 more files in changeset.
- remove globals for errorInfo and use namespace qualifiers instead

  1. … 3 more files in changeset.
- standardize url construction to protect against injection attacks

  1. … 11 more files in changeset.
- improve safety of HTML

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2535 more files in changeset.
- fix invalid pi-doc variable @version and @cvs_id

  1. … 11 more files in changeset.
- replace calls to deprecated "ad_parameter" by non-deprecated counterparts

  1. … 1 more file in changeset.
- replace seemingly unneeded call to "eval" by expand operator

- improve comments

- remove some more "empty_string_p" occurances

  1. … 3 more files in changeset.
- use $$ quoting in postgres SQL

- use name parameter for SQL functions

- provide compatility with pg9

- replace deprecated "acs_sc_call" by "acs_sc::invoke"

- replace deprecated "ad_maybe_redirect_for_registration" by "auth::require_login"

- brace expressions

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- use numeric comparison operator for truth value comparisons

- use "in" or "ni" expression instead of "lsearch"

- bump version number to indicate compatibility with 5.8.1

  1. … 132 more files in changeset.
- replace depreacted "ad_parameter" by parameter::get

- replace deprecated "ad_get_user_id" by "ad_conn user_id"

- replace deprecated "ad_permission_p" by "permission::permission_p"

- replace deprecated "export_url_vars" by "export_vars"

  1. … 24 more files in changeset.
- fix sloppy pseudo-comments to silence automated testing

  1. … 7 more files in changeset.
We use the package_key of attachments for checking if there is already an instance of it under dotlrn.

PG 9.0 compatibility. Changes regarding the usage of sequences in order to avoid errors of 'missing FROM-clause message' on queries.

  1. … 4 more files in changeset.
Using site_node::* api instead of accesing the site_nodes array directly with nsv_array calls.