• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

  1. … 2 more files in changeset.
Cleanup the vestigial moderated_p flag

  1. … 9 more files in changeset.
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

  1. … 5 more files in changeset.
Allow to toggle chat active state from the chat list

  1. … 1 more file in changeset.
Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

  1. … 7 more files in changeset.
Fix typo

admin_p and user_p are actually never displayed, so it doesn't make sense to have them in the select clause. What makes sense is that we filter for those chats we can actually access

base_url is in fact just the package_url from the connection

base_url can be computed just once

Reduce divergency between oracle and postgres codebase and make the query less awkward

  1. … 2 more files in changeset.
Don't overquote URL

Whitespace cleanup + Add editor hints

  1. … 5 more files in changeset.
Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

  1. … 23 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 18 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- apply fresh patches to oacs-5-9 branch

  1. … 53 more files in changeset.
- remove deprecated calls

  1. … 19 more files in changeset.
Add headings

  1. … 2 more files in changeset.
HTML cleanup

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
HTML Strict cleanup. Accessibility improvements.

  1. … 26 more files in changeset.
Rolled back HEAD to the version on the 5.3 branch

  1. … 110 more files in changeset.
reverting pablom's commits to oacs-5-2: see http://openacs.org/forums/message-view?message_id=1042586

  1. … 57 more files in changeset.
Fixing a lot of bad programming techniques and try to get .LRN out of the package, in vain...

  1. … 8 more files in changeset.
"New version of the package"

  1. … 88 more files in changeset.
Merged changes to HEAD ...

  1. … 1556 more files in changeset.
Fix URL to create a new room

brought chat in cvs head to the same level as in oacs-5-2, normalized comparisons and expr (using eq etc.)

  1. … 81 more files in changeset.