• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add proc doc to a bunch of procs, declare some things with explicit namespaces rather than in namespace eval, make some public things private

  1. … 25 more files in changeset.
all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:

#!/bin/bash

for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file

done

And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

  1. … 10 more files in changeset.
make some Notices either warnings or debug and made them more descriptive by generally including the proc name as well bug #1032

  1. … 74 more files in changeset.
Started I18N work (Together with Lars)

Added namespace eval $namespace calls to each file in the tcl dir.

Rooted out some hardcoded text, replaced it with respective calls to

the i18n text catalog text function.

Shuffled around proc creation and calling, so that everything works properly.

  1. … 25 more files in changeset.
add a space

modified the wizard to be nlevel deep. also added more doc. wizard is also modified by Brad Duell

  1. … 1 more file in changeset.
Rolling back patch #239, because #238 didn't work

Applied patch #239

About 60 more ad_procs in acs-templating now have doc strings; still more to go

  1. … 8 more files in changeset.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 74 more files in changeset.
removed FILTER_ABORT code from template::forward as the RP doesn't support the catching of the FILTER_ABORT error as a control structure. Removal of the FILTER_ABORT code allows code to be executed after a template::forward command

  1. … 2 more files in changeset.
cleanup

tested and fixed the template query db api

  1. … 26 more files in changeset.
OpenACS 4.x

  1. … 1321 more files in changeset.
Initial revision

    • -0
    • +205
    ./filter-procs.tcl
  1. … 1321 more files in changeset.