• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
relax default samesite setting for login and session cookies to lax

This change was made because otherwise the "keep me logged in"

is often lost, e.g. also with toplevel navigation requests

(e.g. when navigating to the site via Google)

added "ad_conn bot_p" to check, whether request was initiated by a bot

This feature is based on a simple heuristic based on the user-agent

(which can be certainly extended). It is useful to avoid e.g. Google

bot to run into "notifications subscribe" + login attempts, which

are useful for not-logged-in user, but not for bots. These attemps

lead to failures in google statistics that might reduce the google

ranking of a web site.

Whitespace changes

Deprecate 'f::lambda' in favor of tcllib implementation

fix broken support for explicit bindvars to db_foreach

use common "icanuse" idioms

    • -13
    • +6
    ./tcl/utilities-procs-naviserver.tcl
Keep nsv variable "rp_properties request_count"

The nsv "rp_properties request_count" is still needed for bootstart loader.

Set it at the end of rp initialization

remove misleading comment. there should be no re-init

Whitespace cleanup

Improve sql portability

  1. … 5 more files in changeset.
Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...

Improve portability of test code

Maintain also the has_child cache when mounting a package

Fix typo

cache method "has_children" to avoid frequent (but cheap) DB calls

improve handling of errors, which are triggerd by the error template

improve comments

  1. … 2 more files in changeset.
Whitespace changes + editor hints

    • -111
    • +117
    ./tcl/test/db-proc-test-procs.tcl
Add 'nullchar' test, which uncovers a bug transmitting the null character to postgres. Many thanks to Nathan Coulter for finding out and creating the test as well.

make debug output more compact (shorten long arguments, remove line-breaks)

fix typo

Avoid testing all site nodes on 'site_node_get_children', if the number of them is too large, as it can take too long

    • -24
    • +36
    ./tcl/test/acs-tcl-test-procs.tcl
improve spelling

  1. … 4 more files in changeset.
improve spelling

  1. … 10 more files in changeset.
whitespace changes in *init files

improve spelling

  1. … 1 more file in changeset.
provide a hint to make potential upgrade problems more clear

improve spelling

Skip upgrade attempts when the package is installed and disabled

Avoid skipping datamodel scripts during initial installation