OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 20 Oct 2019
2:52 pm

gustafn

- Fix a tricky Tcl_Obj sharing bug triggered by the usage of C-level

IndexObjs based on volatile tables. Consider the following example:

proc foo {x} {

return [bar -value x ...]

}

The Tcl_Obj "x" is shared as name of argument and as a value of the

non-positional parameter "-value". When bar (e.g. C-implemented)

uses Tcl_GetIndexFromObj*() to lookup "x" in a table of options,

which is volatile, the involved Tcl_Obj will be converted to an

indexObj.

On a call with wrong number of arguments( e.g."foo 1 2 3"), Tcl

will try to give a nice error message, saying that "foo x" can be

called only with one argument. When printing argument "x", it sees

that "x" is an indexObj, and for these kinds of objects, "x" might

be an abbreviated version of a full name. Since the table behind

the indexObj is in the case above volatile, a crash might happen.

The committed fix above is just a temporary measure. NaviServer should

try to avoid such Tcl_Obj conversions in these cases. It is also

questionable, whether the attempt to interpret a argument name as

an abbreviated.

Options
    • -6
    • +7
    ./tcl/utilities-procs-naviserver.tcl
Friday 18 Oct 2019
6:07 pm

antoniop

Whitespace cleanup

Options
    • -14
    • +13
    ./tcl/utilities-procs-naviserver.tcl
Thursday 17 Oct 2019
4:13 pm

antoniop

New test for json and utf-8 encoding against Postman Echo webservice (https://docs.postman-echo.com)

Options
    • -0
    • +93
    ./tcl/test/http-client-procs.tcl
Friday 11 Oct 2019
5:44 pm

gustafn

Switch order of "ns_return 500" and "ad_log error" to see the error message also in cases, where "ns_return 500" will fail due to a already closed connection,

(Many thanks to Franz Penz for the suggestion)

Options
    • -5
    • +4
    ./tcl/request-processor-procs.tcl
Tuesday 08 Oct 2019
6:30 pm

gustafn

Make comma setting more consistent

see: https://onlinewritingtraining.com.au/however-therefore-furthermore/

Options
    • -2
    • +2
    ./tcl/01-database-procs.tcl
    • -2
    • +2
    ./tcl/community-core-procs.tcl
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -1
    • +1
    ./tcl/memoize-procs-aolserver.tcl
    • -2
    • +2
    ./tcl/memoize-procs-naviserver.tcl
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
6:28 pm

gustafn

new API call "http_auth::basic_authentication_decode" to replace 3 distinct implementations of this logic

Options
    • -2
    • +2
    ./acs-tcl.info
    • -14
    • +39
    ./tcl/http-auth-procs.tcl
  3. … 5 more files in changeset.
Sunday 06 Oct 2019
6:22 pm

gustafn

align implementation with code

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
5:45 pm

gustafn

Fix broken test case (broken in many dimensions)

Options
    • -5
    • +17
    ./tcl/test/naviserver-api-procs.tcl
Saturday 05 Oct 2019
2:57 pm

gustafn

modernize Tcl

Options
    • -2
    • +2
    ./tcl/apm-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
  3. … 1 more file in changeset.
2:57 pm

gustafn

remove uneeded flag

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Tuesday 01 Oct 2019
10:51 am

antoniop

Revert cache flushing, as it was solved differently downstream

Options
    • -5
    • +2
    ./tcl/defs-procs.tcl
Monday 30 Sep 2019
4:58 pm

antoniop

Force a complete flush also when setting a global parameter, other than when deleting

This operation seems superfluous upstream, but downstream code has some specific flushing behavior that would otherwise be applied only at deletion. The change is supposed to be merged in a way that will enable such specific flushing downstream

Options
    • -2
    • +5
    ./tcl/defs-procs.tcl
Sunday 29 Sep 2019
6:07 pm

gustafn

new funcion: util::inline_svg_from_dot: refactored version from private api-procs function.

use new function in api-doc

CVS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +70
    ./tcl/utilities-procs.tcl
  3. … 2 more files in changeset.
4:55 pm

gustafn

prefer curly braces for list of options

Options
    • -2
    • +2
    ./tcl/01-database-procs.tcl
4:54 pm

gustafn

provide a better name for link in test case

Options
    • -1
    • +1
    ./tcl/test/html-conversion-procs.tcl
Tuesday 10 Sep 2019
3:04 pm

gustafn

ad_schedule_proc: change default of optional parameter "-thread" to "t" to reduce likelyhood that

main sched thread is blocked to long. While the main sched thread is blocked, no other jobs

will be scheduled. This can lead to potential problems, when scheduled procs should be executed

at certain times.

Options
    • -4
    • +11
    ./tcl/utilities-procs.tcl
Friday 06 Sep 2019
6:00 pm

hectorr

Whitespace changes

Options
    • -13
    • +13
    ./tcl/pdf-procs.tcl
  2. … 2 more files in changeset.
5:58 pm

hectorr

Use 'ns_log Error' for error logging, instead of 'ns_log Notice: Error...'

Options
    • -2
    • +2
    ./tcl/pdf-procs.tcl
  2. … 4 more files in changeset.
5:01 pm

hectorr

Remove the acs-tcl testcase 'documentation__check_proc_testcase', as it provides information already covered by the new 'acs-automated-testing/www/admin/proc-coverage' page and the '::aa::coverage::*' procs

Options
    • -32
    • +1
    ./tcl/test/doc-check-procs.tcl
Thursday 05 Sep 2019
3:47 pm

antoniop

Reimplement portrait retrieval around the user_portrait relationship, as procs such as merge::MergeUserInfo do not assume a certain name format on the cr_item

Options
    • -5
    • +8
    ./tcl/community-core-procs.tcl
Wednesday 04 Sep 2019
6:33 pm

antoniop

Avoid potential quoting issues by enclosing body in a list statement (many thanks to Nathan Coulter)

Options
    • -3
    • +3
    ./tcl/exception-procs.tcl
1:58 pm

antoniop

Fix copy paste

Options
    • -5
    • +1
    ./tcl/test/naviserver-api-procs.tcl
1:51 pm

antoniop

Simple test to make sure available md5 decoding implementations work the same

Options
    • -0
    • +27
    ./tcl/test/naviserver-api-procs.tcl
1:51 pm

antoniop

file naviserver-api-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/naviserver-api-procs.tcl
Tuesday 03 Sep 2019
1:45 pm

antoniop

Reduce divergency between oracle and postgres

Options
    • -36
    • +0
    ./tcl/object-procs-oracle.xql
    • -36
    • +0
    ./tcl/object-procs-postgresql.xql
    • -3
    • +21
    ./tcl/object-procs.tcl
8:35 am

hectorr

Remove unnecessary 'aa_run_with_teardown'

Options
    • -21
    • +17
    ./tcl/test/acs-tcl-apm-procs.tcl
    • -20
    • +12
    ./tcl/test/acs-tcl-test-procs.tcl
    • -8
    • +4
    ./tcl/test/widget-test-procs.tcl
  4. … 1 more file in changeset.
Monday 02 Sep 2019
6:56 pm

hectorr

Add 'db_dml', 'db_0or1row' , 'db_abort_transaction' and 'db_multirow' to the list of covered procs of different testcases

Options
    • -1
    • +6
    ./tcl/test/acs-tcl-test-procs.tcl
6:47 pm

hectorr

Add 'ad_tmpdir' and 'ad_url' to the list of covered procs of different testcases

Options
    • -1
    • +4
    ./tcl/test/application-data-link-procs.tcl
    • -0
    • +2
    ./tcl/test/http-client-procs.tcl
    • -1
    • +5
    ./tcl/test/openacs-kernel-procs.tcl
6:39 pm

hectorr

Add 'xml_doc_get_first_node', 'randomRange', 'whos_online::user_invisible_p' and 'site_node::get_url_from_object_id' to the list of covered procs of different testcases

Options
    • -2
    • +8
    ./tcl/test/acs-tcl-test-procs.tcl
    • -1
    • +2
    ./tcl/test/site-nodes-test-procs.tcl
    • -0
    • +1
    ./tcl/test/whos-online-procs.tcl
6:27 pm

hectorr

Add 'db_string', 'db_list' and 'db_list_of_lists' to the list of covered procs of different testcases

Options
    • -2
    • +10
    ./tcl/test/acs-tcl-test-procs.tcl