• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Centralize retrieval of the test URL

  1. … 4 more files in changeset.
Allow to deprecate ad_page_contract_filters, improve doc

Deprecate color widget api, superseded by HTML5 features

Increase proc coverage

Increase test coverage

Deprecate ad_approval_system_inuse_p

Fix implementation of ad_acs_admin_node so that the node_id is returned as stated in the doc

For the one occurrence that treated this proc as boolean, the result will be the same (e.g. 0 = false and any other id = true)

Test some system information api

The test shows that ad_acs_admin_node has so far returned a boolean, countrary to what the documentation says

file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/acs-kernel-procs.tcl
When demoting a user, flush the permissions cache as well

Test demoting/promoting of a user + a buch of other api

This test fails now when checking if a demoted user is still an swa, one needs to flush the permissions as well

    • -1
    • +103
    ./test/community-core-test-procs.tcl
Test acs_user::ScreenName

    • -1
    • +42
    ./test/community-core-test-procs.tcl
Test acs_object_type_hierarchy

Test acs_object_type::get_table_name

Test acs_object_name api

Test acs_magic_object

Test various URL generating procs

file defs-procs.tcl was initially added on branch oacs-5-10.

Deprecate util_get_current_url, superseded by ad_return_url

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 3 more files in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Reimplement util_subset_p

Deprecate util_report_successful_library_load

Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 8 more files in changeset.
Deprecate export_entire_form

Deprecate util_AnsiDatetoPrettyDate

  1. … 2 more files in changeset.
Deprecate util_report_library_entry

Formatting changes

Deprecate util::string_check_urlsafe

Simplify implementation