Activity OpenACS/openacs-4/packages/acs-tcl/tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	71
Last Commit:	05 Apr
Commits this week:	0
Total Lines of Code (LoC):	65,995
Net change in LoC this week:	0

Commit Activity

last updated 13 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 02 Sep 2021

7:10 pm

antoniop

Cache the information about a package being a singleton and expose into a private api, use the api in parameter::get_from_package_key, called quite often in our downstream pages

- -0
- +12
./apm-init.tcl
- History
- Source
- Diff
./apm-init.tcl
- -2
- +18
./apm-procs.tcl
- History
- Source
- Diff
./apm-procs.tcl
- -6
- +2
./parameter-procs.tcl
- History
- Source
- Diff
./parameter-procs.tcl

Friday 27 Aug 2021

8:36 pm

gustafn

fixed bug in redirects and disabled acs-testing package, changed node info from array to dict

- -20
- +22
./request-processor-procs.tcl
- History
- Source
- Diff
./request-processor-procs.tcl

Friday 20 Aug 2021

11:39 am

gustafn

fix case where the manual slash-parsing in the sitenode code is confused with percent-substitutions

This is just a "quick fix", since the Proper solution in more complex:

# A URL path /%2f/ is syntactically permissible,

# but this is not supported in the current site-nodes code. It

# would be correct, to avoid the parsing of the slashes here and

# to process instead the result of [ns_conn urlv], which is

# already parsed (before the percent substitutions). This would

# probably require the request processor to perform some mangling

# of urlv in vhost cases to set a a proper [ad_conn urlv] ... and

# of course to pass the "urlv" instead of the "url" to the

# slash-parsing functions.

- -2
- +22
./site-nodes-procs.tcl
- History
- Source
- Diff
./site-nodes-procs.tcl

10:38 am

gustafn

add log warnings when include-contract is violated, since (in most cases) the passed values should be pre-checked

- -4
- +13
./tcl-documentation-procs.tcl
- History
- Source
- Diff
./tcl-documentation-procs.tcl

10:36 am

gustafn

improve documentation

- -5
- +7
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl

Tuesday 10 Aug 2021

2:13 pm

antoniop

Fix expression to the original intention: check if ns_conn url ends by ad_conn extra_url

- -4
- +5
./request-processor-procs.tcl
- History
- Source
- Diff
./request-processor-procs.tcl

Friday 06 Aug 2021

6:40 am

gustafn

ad_return_url: experimental change to produce per default a proper encoded result

Background: before this change, ad_return_url encoded always the query

variables but not the URL path. This mixed result is complex to handle

to achieve ex-post a proper encoding. The function has a flag

"-urlencode", which is nowhere used in OpenACS. Other functions like

e.g. export_vars, or pretty_link return per default as well the

encoded URL. "ad_return_url" has a new flag "-path_encode=false" to

obtain the previous behavior (similar to the other mentioned

functions).

- -8
- +19
./defs-procs.tcl
- History
- Source
- Diff
./defs-procs.tcl

Thursday 05 Aug 2021

7:36 pm

gustafn

break overlong lines and improve comments

- -75
- +107
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl

Tuesday 03 Aug 2021

9:28 pm

gustafn

improve spelling

- -2
- +2
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl

9:22 pm

gustafn

provide a compatibility function for ns_parsehostport for earlier versions of NaviServer

- -3
- +18
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Monday 02 Aug 2021

11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

- -6
- +3
./01-database-procs.tcl
- History
- Source
- Diff
./01-database-procs.tcl
- -4
- +3
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
- -9
- +5
./pdf-procs.tcl
- History
- Source
- Diff
./pdf-procs.tcl
- -3
- +2
./utilities-procs-aolserver.tcl
- History
- Source
- Diff
./utilities-procs-aolserver.tcl
- -12
- +7
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
… 3 more files in changeset.

10:00 pm

gustafn

fix header generation

since the headers are set in a loop, "ns_set put" is incorrect

since it is additive. "ns_set update" is correct.

- -1
- +1
./test/http-client-procs.tcl
- History
- Source
- Diff
./test/http-client-procs.tcl

7:38 pm

gustafn

make using page-filter "object_id" backwards compatible by allowing it to be used also during update scripts

- -5
- +20
./tcl-documentation-procs.tcl
- History
- Source
- Diff
./tcl-documentation-procs.tcl
… 1 more file in changeset.

7:36 pm

gustafn

improve spelling

- -1
- +1
./test/security-procs.tcl
- History
- Source
- Diff
./test/security-procs.tcl

Thursday 29 Jul 2021

4:38 pm

hectorr

Adapt 'ad_urlencode_url' to the new 'ns_parseurl' stricter behavior

- -17
- +33
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl

Thursday 08 Jul 2021

11:04 pm

gustafn

added "ns_parseurl -strict" to icanuse definitions

- -0
- +1
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Friday 02 Jul 2021

7:36 pm

antoniop

Make so that also party::update enforces emails to be lowercase, add/extend automated tests to make sure emails are lowercase everywhere

- -2
- +3
./community-core-procs.tcl
- History
- Source
- Diff
./community-core-procs.tcl
- -3
- +1
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
- -2
- +15
./test/community-core-test-procs.tcl
- History
- Source
- Diff
./test/community-core-test-procs.tcl

2:02 pm

hectorr

Refine regex and extend tests

- -2
- +2
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
- -0
- +1
./test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
./test/acs-tcl-test-procs.tcl

Thursday 01 Jul 2021

6:33 pm

hectorr

Extend 'acs_tcl__util_url_valid_p' test case

- -1
- +1
./test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
./test/acs-tcl-test-procs.tcl

6:28 pm

hectorr

Make the check for relative URLs less strict to cover some valid cases (see RFC 1808) and extend test cases.

- -3
- +11
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
- -4
- +33
./test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
./test/acs-tcl-test-procs.tcl

3:52 pm

hectorr

Add the 'relative' flag to 'util_url_valid_p', to check also relative URLs. Extend 'acs_tcl__util_url_valid_p' test case and bump package version.

- -4
- +27
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
- -5
- +44
./test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
./test/acs-tcl-test-procs.tcl
… 1 more file in changeset.

12:36 pm

hectorr

Refine URL validation regexp and extend 'acs_tcl__util_url_valid_p' test case.

- -2
- +5
./utilities-procs.tcl
- History
- Source
- Diff
./utilities-procs.tcl
- -0
- +63
./test/acs-tcl-test-procs.tcl
- History
- Source
- Diff
./test/acs-tcl-test-procs.tcl

Thursday 24 Jun 2021

1:36 pm

hectorr

Reuse email validation logic

- -2
- +2
./tcl-documentation-procs.tcl
- History
- Source
- Diff
./tcl-documentation-procs.tcl

1:31 pm

Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers.