• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

  1. … 1 more file in changeset.
Document public api

  1. … 1 more file in changeset.
Add doc to public api, fix obvious bug

Document public api

  1. … 1 more file in changeset.
Deprecate util_get_current_url, superseded by ad_return_url

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 5 more files in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Reimplement util_subset_p

Deprecate util_report_successful_library_load

Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 9 more files in changeset.
Deprecate export_entire_form

Deprecate util_AnsiDatetoPrettyDate

  1. … 2 more files in changeset.
Deprecate util_report_library_entry

Formatting changes

Deprecate util::string_check_urlsafe

Simplify implementation

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Cleanup duplicated and slower proc definition

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 13 more files in changeset.
Generalized "version_dir" handling a little for download specs

The problem was that bootstrap5 uses a version directory, which

consists of the version plus an extra string element. The previous

version assumed that the version is always used as a directory name.

Whe track now the versionDir information in the resource_info dict and

use this, when available (otherwise the version number is used as before).

The resource_info dict contains now the following path components:

# Provide paths for loading either via /resources/ or CDN


# "resourceDir" is the absolute path in the filesystem

# "resourceUrl" is the URL path provided to the request processor

# "versionDir" is the version-specific element both in the

# URL and in the filesystem.


bumped acs-tcl to 5.10.1d19

  1. … 2 more files in changeset.
Deprecate ad_apply, made obsolete in modern Tcl by the expansion operator "{*}"

  1. … 4 more files in changeset.
provided a default value for udp:// requests

whitespace cleanup

added sni hostname and redirect on 301 and 302

Added new private helper proc ::util::resources::download_helper

to deal with redirects on github, when "util::http::get" is used.

Provide better debug info in case "ns_parseurl" fails inside util::split_location

Factor our private function "util::ns_set_pretty_print" which might be

used also on other occasions.

rework of ad_decode

- modernize code

- improve performance

- extend regression test

  1. … 1 more file in changeset.
improve spelling and formulations

  1. … 2 more files in changeset.
util::file_content_check: new utility for checking content of a file

Check whether the provided file is of the requested type.

This function is more robust and protable than relying on

external programs and their output, but it does not work on

all possible file types. It checks a few common cases that

could lead to problems otherwise, like when uploading archives.

Bump version to 5.10.1d9

  1. … 2 more files in changeset.
improve spelling

  1. … 2 more files in changeset.