OpenACS / openacs-4 / packages / acs-tcl / tcl / test

html-conversion-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 12:40
Commits this week: 0
Total Lines of Code (LoC): 591
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Aug 2022
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -6
    • +17
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
12:34 pm

gustafn

improve spelling

Options
    • -10
    • +69
    ./html-conversion-procs.tcl
  2. … 6 more files in changeset.
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -2
    • +0
    ./html-conversion-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -5
    • +14
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
Friday 04 Mar 2022
3:46 pm

hectorr

Fix quote_unquote_html test

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
Wednesday 02 Mar 2022
6:01 pm

gustafn

Make ad_html_security_check configurable

ad_html_security_check has now three optional attributes

to make it configurable for different situations

-allowed_tags

-allowed_attributes

-allowed_protocols

If these attributes are not specified, the behavior is exactly like

before. This change makes it also easier to regression test this

function, since the behavior does not necessarily depend on a site's

parameter settings.

The function was also modernized, new regression tests were added.

Options
    • -20
    • +39
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
Tuesday 16 Feb 2021
9:59 pm

gustafn

improve listing of test coverage

Options
    • -6
    • +35
    ./html-conversion-procs.tcl
  2. … 17 more files in changeset.
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
  2. … 16 more files in changeset.
Saturday 06 Jun 2020
11:42 am

gustafn

improve comments and spelling

Options
    • -2
    • +2
    ./html-conversion-procs.tcl
  2. … 2 more files in changeset.
Monday 16 Dec 2019
6:55 pm

antoniop

Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

Options
    • -28
    • +28
    ./html-conversion-procs.tcl
  2. … 11 more files in changeset.
Sunday 29 Sep 2019
4:54 pm

gustafn

provide a better name for link in test case

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
Thursday 04 Jul 2019
4:14 pm

gustafn

add "blob" to the checked attributes

Options
    • -0
    • +2
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
Wednesday 03 Jul 2019
8:12 pm

gustafn

add checking for javascript and data protocols (fixes issue #3413)

Options
    • -1
    • +17
    ./html-conversion-procs.tcl
  2. … 3 more files in changeset.
Sunday 10 Mar 2019
10:34 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
  2. … 14 more files in changeset.
Saturday 03 Nov 2018
12:08 pm

gustafn

whitespace cleanup

Options
    • -36
    • +36
    ./html-conversion-procs.tcl
  2. … 11 more files in changeset.
Tuesday 23 Oct 2018
8:38 pm

gustafn

improving ad_html_to_text:

- handle src specs with "data:" (skip data)

- handle anchors with empty hrefs and internal links by not adding these to the text rendering

- add test cases to regression test

Options
    • -1
    • +43
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
Wednesday 25 Jul 2018
3:42 pm

gustafn

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

Options
    • -29
    • +174
    ./html-conversion-procs.tcl
  2. … 18 more files in changeset.
Sunday 22 Jul 2018
11:58 am

gustafn

prefer "aa_equals" over "aa_true"+"string equal"

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
  2. … 5 more files in changeset.
Wednesday 18 Jul 2018
8:54 pm

hectorr

Whitespace cleanup

Options
    • -22
    • +22
    ./html-conversion-procs.tcl
7:26 pm

hectorr

Add 'Markdown' tests for 'ad_html_text_convert'

Options
    • -0
    • +14
    ./html-conversion-procs.tcl
Tuesday 17 Jul 2018
4:25 pm

antoniop

Add trivial tests for the other different kinds of space

Options
    • -0
    • +4
    ./html-conversion-procs.tcl
Thursday 15 Mar 2018
1:33 pm

gustafn

- provide test case for html-to-text conversion

- provide a version of html-to-text based on ns_reflow_text

Options
    • -0
    • +81
    ./html-conversion-procs.tcl
  2. … 2 more files in changeset.
Saturday 30 Sep 2017
8:12 pm

gustafn

Bug fix: avoid confusion between text argument and option, when text starts with "-"

Options
    • -2
    • +2
    ./html-conversion-procs.tcl
  2. … 36 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -4
    • +10
    ./html-conversion-procs.tcl
  2. … 7834 more files in changeset.
Monday 13 Feb 2017
2:44 pm

gustafn

Fix test cases for text conversion

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
Saturday 26 Sep 2015
1:25 pm

gustafn

- increase robsutness of apm_package_installed_p_not_cached

- make ad_unquote capable to unquote ns_qutehtml

- fix test cases

Options
    • -2
    • +2
    ./html-conversion-procs.tcl
  2. … 4 more files in changeset.
Friday 18 Sep 2015
9:27 am

gustafn

- prefer ns_quotehtml over ad_quotehtml

Options
    • -1
    • +1
    ./html-conversion-procs.tcl
  2. … 36 more files in changeset.
Thursday 10 Sep 2015
10:21 am

gustafn

- add editor hints to keep spaces/tabs in the furture more consistent

Options
    • -0
    • +6
    ./html-conversion-procs.tcl
  2. … 754 more files in changeset.
Sunday 12 Jul 2009
3:10 am

donb

Non-info file merge results, with conflicts fixed

Options
    • -7
    • +7
    ./html-conversion-procs.tcl
  2. … 726 more files in changeset.
Sunday 17 May 2009
2:48 am

donb

Fixed tests to match the tDOM-based tag closing code.

Options
    • -5
    • +5
    ./html-conversion-procs.tcl