Activity OpenACS/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	5
Last Commit:	05 Apr
Commits this week:	0
Total Lines of Code (LoC):	1,981
Net change in LoC this week:	0

Commit Activity

last updated 7 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Monday 02 Aug 2021

11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

- -4
- +3
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 7 more files in changeset.

Friday 12 Mar 2021

11:24 am

antoniop

Remove extra decoding ns_parsequery provides it already

- -2
- +0
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

Thursday 11 Mar 2021

11:46 am

antoniop

Use naviserver api to parse URL variables

- -12
- +5
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 1 more file in changeset.

Thursday 14 Jan 2021

10:35 pm

gustafn

Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

- -1
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 2 more files in changeset.

3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

- -9
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 1 more file in changeset.

Wednesday 13 Jan 2021

2:16 pm

antoniop

Keep supporting the previous proc signature, throwing a warning

- -0
- +5
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

2:10 pm

antoniop

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

- -2
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 1 more file in changeset.

1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

- -1
- +4
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 1 more file in changeset.

12:25 pm

antoniop

Fix version check

- -1
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

12:00 pm

antoniop

Tear down a lot of boilerplate used to support native HTTP api on Naviserver versions < 4.99.15, which will now fallback to curl

- -245
- +40
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 1 more file in changeset.

11:09 am

antoniop

Doc formatting changes

- -330
- +406
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

10:44 am

antoniop

Avoid markup in documentation

- -72
- +69
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

10:37 am

antoniop

Reduce people expectations

- -1
- +2
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

Wednesday 28 Oct 2020

4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

- -5
- +5
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 58 more files in changeset.

Tuesday 11 Aug 2020

10:44 pm

gustafn

improve spelling

- -5
- +5
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 4 more files in changeset.

Thursday 06 Aug 2020

3:09 pm

gustafn

improve spelling

- -2
- +2
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 6 more files in changeset.

Tuesday 04 Aug 2020

11:35 am

gustafn

improve spelling

- -2
- +2
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 5 more files in changeset.

Tuesday 28 Jul 2020

1:08 pm

gustafn

added support for SNI servers

- -1
- +4
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

Monday 13 Jul 2020

2:02 pm

gustafn

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

- -4
- +4
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 50 more files in changeset.

Friday 03 Jul 2020

9:27 am

gustafn

improve spelling: move closer to the linux documentation recommendations

- -1
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 34 more files in changeset.

Thursday 09 Jan 2020

4:43 pm

antoniop

Satisfy acs-tcl.postman_echo test case for curl http client implementation:

as with curl we always spool the body of requests into a file, we need to convert to the proper encoding even when this is already that of the system

- -1
- +1
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

Thursday 29 Nov 2018

2:52 pm

antoniop

More
MAIN:antoniop:20181129135237
changed 1 file
MAIN

Wrap legacy and current ns_http api behavior in a proc with a common interface in a way that people with newer Naviserver can exploit e.g. ns_http run capabilities (in particular, not being forced to queue and potentially block concurrent HTTP requests)