OpenACS / openacs-4 / packages / acs-tcl / tcl

form-processing-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 20
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 1,387
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Mar 2023
2:38 pm

antoniop

Update api

Options
    • -5
    • +1
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
Friday 15 Jul 2022
1:05 pm

antoniop

Don't append an extra empty string to the form command when we are dealing with flags (that have therefore no value)

Fixes regression from https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20220331163354, because now we treat flags properly

Options
    • -2
    • +5
    ./form-processing-procs.tcl
Sunday 23 May 2021
7:57 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 5 more files in changeset.
Friday 23 Apr 2021
11:01 am

gernst

Remove non-functional "double click protection" in order to remove a potential attack vector

Options
    • -14
    • +0
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
Saturday 27 Feb 2021
11:25 pm

gustafn

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 7 more files in changeset.
Thursday 18 Feb 2021
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 15 more files in changeset.
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -7
    • +7
    ./form-processing-procs.tcl
  2. … 58 more files in changeset.
Thursday 19 Dec 2019
8:15 pm

gustafn

address issue #3433: add option "noquote" for the "inform" widget type

The flag is currently ignored for all other widget types

Options
    • -0
    • +1
    ./form-processing-procs.tcl
  2. … 2 more files in changeset.
Tuesday 08 Oct 2019
6:30 pm

gustafn

Make comma setting more consistent

see: https://onlinewritingtraining.com.au/however-therefore-furthermore/

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 6 more files in changeset.
Tuesday 27 Aug 2019
11:56 am

antoniop

Try to address issue reported by Michael Aram: export variables sooner, when the uplevel they come from is still well known, rather than later in the rendering, when this could not be so trivial (e.g. in OO code)

Options
    • -5
    • +6
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
Friday 05 Jul 2019
12:00 pm

hectorr

ad_form: allow multiple files in 'template::widget::file' by using the 'multiple' attribute of the input tag, new on HTML5.

- Pass the 'multiple' flag to 'template::element::create', so it can be used by widgets to modify their behavior.

- Update 'template::element::create' doc.

- This opens the door to reducing the number of widgets by combining single and multivalued ones into one (for instance, 'multiselect' and 'select' widgets), in the same way the 'file' widget does now.

Options
    • -6
    • +1
    ./form-processing-procs.tcl
  2. … 2 more files in changeset.
Thursday 25 Apr 2019
9:24 pm

gustafn

it seems, that "-ulevel" is used more often than "-level"

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
9:21 pm

gustafn

use "-level" instead of "-ulevel", since "-level" is used e.g. in

template::util::multirow_to_list or template::util::list_of_ns_sets_to_multirow

as well.

Options
    • -1
    • +4
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
6:39 pm

gernst

Added switch "-ulevel" to proc "util::var_subst_quotehtml";

ad_form: quote form field values in validation error messages to prevent XSS attacks

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
Sunday 10 Mar 2019
10:34 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./form-processing-procs.tcl
  2. … 14 more files in changeset.
Monday 11 Feb 2019
12:53 pm

gustafn

fix typos

Options
    • -2
    • +2
    ./form-processing-procs.tcl
Saturday 09 Feb 2019
2:58 pm

antoniop

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

Options
    • -243
    • +229
    ./form-processing-procs.tcl
Friday 08 Feb 2019
2:19 am

gustafn

reflow overlong lines in comments

Options
    • -52
    • +75
    ./form-processing-procs.tcl
2:07 am

gustafn

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

Options
    • -5
    • +35
    ./form-processing-procs.tcl
1:43 am

gustafn

white space changes

Options
    • -12
    • +19
    ./form-processing-procs.tcl
1:41 am

gustafn

simplify code

Options
    • -13
    • +3
    ./form-processing-procs.tcl
Tuesday 05 Feb 2019
4:19 pm

gustafn

improve security of ad_forms by binding request to a user

Options
    • -4
    • +16
    ./form-processing-procs.tcl
4:18 pm

gustafn

fix bracket in last commit

Options
    • -1
    • +1
    ./form-processing-procs.tcl
4:09 pm

gustafn

use usual idioms, white space changes

Options
    • -78
    • +77
    ./form-processing-procs.tcl
Friday 28 Dec 2018
12:24 pm

antoniop

Greatly reduce complexity of code required to support -export flag for ad_form:

instead of juggle variables around to mimick export_vars, just set -export flag

value as a form property, then use the real export_vars on it later when form

is rendered. This will support all current features (e.g. :multiple, :sign, :array)

more reliably and reduce code duplication.

Options
    • -80
    • +5
    ./form-processing-procs.tcl
  2. … 1 more file in changeset.
Thursday 17 May 2018
9:43 am

gustafn

improve wording

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 7 more files in changeset.
Monday 14 May 2018
3:22 pm

gustafn

make spelling of names more consistent

Options
    • -3
    • +3
    ./form-processing-procs.tcl
  2. … 5 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -7
    • +7
    ./form-processing-procs.tcl
  2. … 475 more files in changeset.
Wednesday 25 Apr 2018
9:23 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -7
    • +7
    ./form-processing-procs.tcl
  2. … 71 more files in changeset.
Wednesday 04 Apr 2018
8:51 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./form-processing-procs.tcl
  2. … 34 more files in changeset.