• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Allow ad_return_url to be called also, when connection is closed.

This might be the case e.g. for the search renderer. In this case, a default_url is used

  1. … 3 more files in changeset.
Use localized message when returning 403 and no custom message is specified

Whitespace changeds

  1. … 3 more files in changeset.
Harmonize parameter names in proc documentation removing unnecessary hyphens

  1. … 4 more files in changeset.
Fix typos

  1. … 11 more files in changeset.
Use more API

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
reduce stress on util_memoize_cache by using per-thread cache for acs::version number

Fix for bug #3335 (as suggested by Michael Aram)

  1. … 1 more file in changeset.
Move deprecated procs into deprecated-procs.tcl

  1. … 1 more file in changeset.
Fix more typos

  1. … 11 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Standardize spellings of names

  1. … 6 more files in changeset.
- Refactor ad_get_login_url reduce replicated code and to make semantics clearer

- ad_get_login_url handles now as well cases, where a subsite is mapped to an application package on a subsite

- fix a bug in util_current_location in connection with hostnode map

  1. … 2 more files in changeset.
no need to quote in the quoted string

Improve indentation

- replace javascript: urls by event listeners

  1. … 2 more files in changeset.
- adding nonce values to script tags

  1. … 11 more files in changeset.
- fix bug for host-node-mapped subsites: on the (subsite) admin-page

of a host-node-mapped subsites, the link to site-wide-admin should

always point to the main site.

- add new helper function util::configured_location to address the bug

above to return the configured location as configured for the

current network driver. While [util_current_location] honors the

virtual host information of the host header field,

util::configured_location returns the main configured location

(probably the main subsite).

- extend [util_driver_info]

* make the passed-in array name optional and to return always a dict

* include the configured host name in the result (dict/array)

- add cross references via @see to make it easier to switch between

related functions

- bump version number of acs-tcl to 5.9.1d10 and acs-subsite to

5.9.1d7 to address dependencies

  1. … 6 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
- adjust return status information

- use 422 (Unprocessable Entity) for complaints, which are mostly coming from page-contracts

  1. … 1 more file in changeset.
- standardize url construction to protect against injection attacks

  1. … 5 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- mark more of the functions as deprecated which are not called

by the major 80 packages and for which popular alternatives exist

* pkg_home (-> acs_package_root_dir)

* ad_get_user_info (-> acs_user::get)

* exists_or_null (-> tcl builtins)

* lmap (danger, this function is a built-in of Tcl 8.6)

* template::util::server_root (-> $::acs::rootdir)

* template::util::display_value (-> ns_log)

* template::util::proper_noun (-> string totitle)

* template::util::string_range (-> string range)

* template::util::get_cookie (-> ad_get_cookie)

* template::util::set_cookie (-> ad_set_cookie)

* template::util::clear_cookie (-> ad_set_cookie)

- util_wrap_list: fix bug, when length of first word less then indent

(space was missing)

  1. … 5 more files in changeset.
- mark functions as deprecated which are called only by deprecated functions

  1. … 2 more files in changeset.
- use "... eq {} " instead of "template::util::is_nil" where it is clear that the variable exists

  1. … 1 more file in changeset.
- don't use backslash in multiline expressions

- make long expressions more uniform and more readable

- use "in" or not in (ni) operator instead of lsearch

- brace expressions to allow for tcl compilation

- bump version number

  1. … 23 more files in changeset.
- get rid of deprecated call to ad_header_with_extra_stuff

- use standard templating

  1. … 1 more file in changeset.