• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed unused sql statements, removed inline sql to rely on xql one, small refactor to better use the api instead of direct sql.

  1. … 3 more files in changeset.
Fix apm tarball file generation (many thanks to Michael Feurstein for report)

Increase timeout to 5 minutes for util::http and pure ns_http implementations (required on slow connections)

- prefer braces around sql statements

  1. … 3 more files in changeset.
.xql-file reform of acs-tcl (part 1)

- remove sql statements from the code, where these are provided via .xql

- prefer empty sql statements over various forms of *SQL*

  1. … 7 more files in changeset.
- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

  1. … 13 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 36 more files in changeset.
- remove globals for errorInfo/errorCode and use namespace qualifiers instead

  1. … 12 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- mark more of the functions as deprecated which are not called

by the major 80 packages and for which popular alternatives exist

* pkg_home (-> acs_package_root_dir)

* ad_get_user_info (-> acs_user::get)

* exists_or_null (-> tcl builtins)

* lmap (danger, this function is a built-in of Tcl 8.6)

* template::util::server_root (-> $::acs::rootdir)

* template::util::display_value (-> ns_log)

* template::util::proper_noun (-> string totitle)

* template::util::string_range (-> string range)

* template::util::get_cookie (-> ad_get_cookie)

* template::util::set_cookie (-> ad_set_cookie)

* template::util::clear_cookie (-> ad_set_cookie)

- util_wrap_list: fix bug, when length of first word less then indent

(space was missing)

  1. … 5 more files in changeset.
- use expand operator rather than eval to reduce likelyhood of

unwanted interference and to improve security

  1. … 9 more files in changeset.
- improve error message

- use computed file name in apm_transfer_file

- use util::http::* as well in apm_transfer_file

- use more safe version comparison

- output same debug line for every transfer method

- The C-library function tmpnam() is deprecated since a while. Therefore naviserver has deprecated ns_tmpnam as well.

Therefore we introduce a new function "ad_tmpnam" which requires just a minimal change and uses ns_mktemp.

  1. … 27 more files in changeset.
- remove tabs in favor of spaces

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

  1. … 14 more files in changeset.
- don't use backslash in multiline expressions

- make long expressions more uniform and more readable

- use "in" or not in (ni) operator instead of lsearch

- brace expressions to allow for tcl compilation

- bump version number

  1. … 23 more files in changeset.
- follow usual indenting convention

- don't abbreviate subcommands

  1. … 4 more files in changeset.
- use "lassign" instead of "util_unlist"

  1. … 19 more files in changeset.
- remove deprecated calls

  1. … 2 more files in changeset.
- follow redirects when downloading .apm files

- guard against older versions of naviserver

- set timeout on queue command

- use ns_http for file transfer when available

- Provide windows compatibility for "upgrade/install" from repository.

Fixed Issues:

windows has no /dev/null,

don't use "gunzip" but "gzip -d",

gzip requires on windows -S switch,

no sh (instead of "cd DIR; tar ..." use "tar ... -C")

no mv (use "file rename" instead)

broken downloads via ns_httpopen + fcopy

  1. … 2 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.