Activity OpenACS/openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	3
Last Commit:	18:21
Commits this week:	0
Total Lines of Code (LoC):	0
Net change in LoC this week:	0

Commit Activity

last updated 1 hour ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 14 Jan 2021

10:35 pm

gustafn

Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

- -14
- +19
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 2 more files in changeset.

3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

- -0
- +4
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 1 more file in changeset.

3:32 pm

antoniop

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

- -1
- +1
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

3:17 pm

antoniop

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

- -2
- +8
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Wednesday 09 Dec 2020

3:36 pm

antoniop

Bring existing doc in the api-doc, so that documentation__check_proc_doc test case does not complain

- -14
- +16
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Tuesday 08 Dec 2020

8:38 pm

gustafn

added backward compatibility proc for AOLserver "ns_trim"

- -1
- +30
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 1 more file in changeset.

Saturday 07 Nov 2020

4:55 pm

gustafn

add i-can-use rule for "ns_urlencode -part oauth1"

- -0
- +1
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Wednesday 28 Oct 2020

4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

- -3
- +3
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 58 more files in changeset.

Saturday 26 Sep 2020

1:40 pm

gustafn

added "ad_conn bot_p" to check, whether request was initiated by a bot

This feature is based on a simple heuristic based on the user-agent

(which can be certainly extended). It is useful to avoid e.g. Google

bot to run into "notifications subscribe" + login attempts, which

are useful for not-logged-in user, but not for bots. These attemps

lead to failures in google statistics that might reduce the google

ranking of a web site.

- -12
- +8
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 2 more files in changeset.

Monday 21 Sep 2020

1:28 pm

gustafn

use common "icanuse" idioms

- -4
- +5
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 1 more file in changeset.

Thursday 06 Aug 2020

3:09 pm

gustafn

improve spelling

- -1
- +1
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 6 more files in changeset.

3:01 pm

gustafn

provide a hint to make potential upgrade problems more clear

- -0
- +7
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Thursday 23 Jul 2020

1:58 pm

gustafn

provdide "icanuse" support for "ns_ictl trace idle"

- -0
- +2
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Wednesday 22 Jul 2020

2:34 pm

antoniop

Provide doc for ns_dbquotelist when is tcl implemented as fallback (fixes documentation__check_proc_doc automated test)

- -5
- +10
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl

Saturday 06 Jun 2020

11:47 am

gustafn

- icanuse: added nsv_dict

- bumped version number to 5.10.0d37

- -0
- +13
./00-icanuse-procs.tcl
- History
- Source
- Diff
./00-icanuse-procs.tcl
… 1 more file in changeset.

Monday 25 May 2020

12:21 pm

As Keith reported, there is was one more issue concerning missing column_names and empty query results. This is now as well fixed in oacs-5-10. Also, the regression test was extended to handle these cases as well.