• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

  1. … 7 more files in changeset.
Make package_id explicit

Add 'acs_subsite_rel_segment_new' test case, covering 'rel_segment::new', 'rel_segment::delete' and 'group::get_rel_segment'

Add 'acs_subsite_application_group_new' test case, covering 'application_group::new' and 'application_group::delete'

Add 'acs_subsite_rel_type_roles' test case, covering 'rel_types::create_role' and 'rel_types::create_role'

Add 'acs_subsite_relation_procs' test case, covering 'relation_add', 'relation_remove', 'relation::get_object_one', 'relation::get_object_two', 'relation::get_objects' and 'relation::get_id'

Whitespace changes

Use the new 'email' input type widget

  1. … 1 more file in changeset.
Use the new 'email' input type widget

Whitespace changes

Use the new 'url' and 'email' input type widgets

improve test coverage

Add 'acs_subsite_attribute_datatypes' test case, covering 'attribute::translate_datatype' and 'attribute::datatype_validator_exists_p' procs

Remove unnecessary aliases

Add 'attribute::value_add' and 'attribute::value_delete' to the 'acs_subsite_attributes' test case

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
Remove leftovers

Whitespace changes

Add new test 'acs_subsite_attributes' covering the 'attribute::add', 'attribute::exists_p' and 'attribute::delete' procs

prefer ns_dbquotevalue over db_quote, mark latter as deprecated

  1. … 3 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 11 more files in changeset.
make end of options explicit

  1. … 12 more files in changeset.
address issue #3456

fix typos

fix for issue #3455

add explicit cast to all max_n_rels with value null to increase readability and to ease function disambiguation

    • -11
    • +11
    ./sql/postgresql/user-profiles-create.sql
  1. … 4 more files in changeset.
Add missing var

Add include contract

Whitespace cleanup