OpenACS / openacs-4 / packages / acs-subsite / www

user

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 903
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Feb 2018
3:00 pm

antoniop

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

Options
    • -16
    • +6
    ./portrait/index.tcl
    • -19
    • +0
    ./portrait/upload-oracle.xql
    • -22
    • +0
    ./portrait/upload-postgresql.xql
    • -75
    • +15
    ./portrait/upload.tcl
    • -38
    • +0
    ./portrait/upload.xql
  6. … 12 more files in changeset.
Monday 19 Feb 2018
1:31 pm

hectorr

fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Options
    • -3
    • +5
    ./portrait/upload.tcl
Sunday 21 Jan 2018
1:35 am

gustafn

Use consistently ad_script_abort after ad_return_error.

Break long lines

Options
    • -4
    • +5
    ./password-reset.tcl
    • -2
    • +5
    ./password-update.tcl
    • -3
    • +5
    ./portrait/comment-edit.tcl
    • -3
    • +5
    ./portrait/upload.tcl
  5. … 21 more files in changeset.
Friday 19 Jan 2018
3:09 pm

gustafn

add ad_script_abort after ad_returnredirect to make termination intent explicit

Options
    • -1
    • +2
    ./portrait/comment-edit.tcl
  2. … 48 more files in changeset.
Friday 05 Jan 2018
11:40 pm

gustafn

make sure to call ad_script_abort after ad_returnredirect

Options
    • -0
    • +3
    ./email-privacy-level.tcl
  2. … 15 more files in changeset.
11:29 pm

gustafn

make sure to call ad_script_abort after ad_returnredirect

Options
    • -4
    • +6
    ./portrait/upload.tcl
  2. … 2 more files in changeset.
Sunday 01 Oct 2017
2:09 pm

gustafn

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

Options
    • -2
    • +2
    ./password-reset.tcl
    • -4
    • +4
    ./password-update.tcl
  3. … 80 more files in changeset.
Wednesday 16 Aug 2017
11:18 am

antoniop

Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

Options
    • -33
    • +5
    ./portrait/erase.tcl
    • -46
    • +0
    ./portrait/erase.xql
  3. … 1 more file in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -1
    • +1
    ./basic-info-update.adp
    • -4
    • +9
    ./basic-info-update.tcl
    • -4
    • +13
    ./email-privacy-level.tcl
    • -2
    • +8
    ./password-reset.tcl
    • -2
    • +8
    ./password-update.tcl
    • -2
    • +8
    ./portrait/comment-edit.tcl
    • -1
    • +1
    ./portrait/erase.adp
    • -2
    • +8
    ./portrait/erase.tcl
    • -4
    • +4
    ./portrait/index.adp
    • -15
    • +26
    ./portrait/index.tcl
    • -6
    • +12
    ./portrait/upload.tcl
  12. … 7824 more files in changeset.
Wednesday 26 Apr 2017
8:58 pm

gustafn

Reflow content

Options
    • -2
    • +6
    ./email-privacy-level.tcl
Wednesday 18 Jan 2017
9:05 am

gustafn

- make boolean tests in .adp files more uniform

Options
    • -1
    • +1
    ./portrait/erase.adp
    • -3
    • +3
    ./portrait/index.adp
  3. … 55 more files in changeset.
Friday 20 May 2016
10:02 pm

gustafn

- prefer "localurl" over "return_url" of name of page filter

Options
    • -2
    • +2
    ./basic-info-update.tcl
    • -1
    • +1
    ./email-privacy-level.tcl
    • -2
    • +2
    ./password-reset.tcl
    • -2
    • +2
    ./password-update.tcl
    • -2
    • +2
    ./portrait/comment-edit.tcl
    • -2
    • +2
    ./portrait/erase.tcl
    • -2
    • +2
    ./portrait/index.tcl
    • -2
    • +2
    ./portrait/upload.tcl
  9. … 83 more files in changeset.
8:13 pm

gustafn

- improve checking of return_urls in page_contracts

Options
    • -2
    • +2
    ./basic-info-update.tcl
    • -1
    • +1
    ./email-privacy-level.tcl
    • -2
    • +2
    ./password-reset.tcl
    • -2
    • +2
    ./password-update.tcl
    • -2
    • +2
    ./portrait/comment-edit.tcl
    • -2
    • +2
    ./portrait/erase.tcl
    • -2
    • +2
    ./portrait/index.tcl
    • -2
    • +2
    ./portrait/upload.tcl
  9. … 80 more files in changeset.
Saturday 27 Feb 2016
5:44 am

gustafn

- fix quoting in SQL

- make code more robust

Options
    • -3
    • +6
    ./portrait/index.tcl
Saturday 02 Jan 2016
9:57 pm

gustafn

- write sql statements between curly braces

Options
    • -11
    • +13
    ./portrait/index.tcl
  2. … 14 more files in changeset.
1:42 pm

gustafn

.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

Options
    • -5
    • +5
    ./portrait/upload.tcl
  2. … 26 more files in changeset.
Monday 14 Dec 2015
7:06 pm

gustafn

- fix old security hole, that allowed to download arbitrary files given a known item_id

Options
    • -1
    • +1
    ./portrait/index.adp
    • -3
    • +3
    ./portrait/index.tcl
  3. … 5 more files in changeset.
Tuesday 22 Sep 2015
2:36 pm

gustafn

- pass values via reference

Options
    • -1
    • +1
    ./basic-info-update.adp
    • -3
    • +2
    ./basic-info-update.tcl
  3. … 1 more file in changeset.
Thursday 10 Sep 2015
10:21 am

gustafn

- add editor hints to keep spaces/tabs in the furture more consistent

Options
    • -1
    • +7
    ./basic-info-update.tcl
    • -1
    • +6
    ./email-privacy-level.tcl
    • -1
    • +7
    ./password-reset.tcl
    • -1
    • +7
    ./password-update.tcl
    • -1
    • +7
    ./portrait/comment-edit.tcl
    • -1
    • +7
    ./portrait/erase.tcl
    • -1
    • +7
    ./portrait/index.tcl
    • -1
    • +7
    ./portrait/upload.tcl
  9. … 747 more files in changeset.
Wednesday 15 Jul 2015
12:26 am

gustafn

- standardize argument passing to adp-includes, don't perform double i18n and double quoting

Options
    • -1
    • +1
    ./basic-info-update.adp
  2. … 124 more files in changeset.
Friday 03 Jul 2015
12:25 pm

gustafn

- fix and standardize quoting in template properties

Options
    • -2
    • +2
    ./basic-info-update.adp
    • -1
    • +1
    ./email-privacy-level.adp
    • -1
    • +1
    ./password-reset.adp
    • -2
    • +2
    ./password-update.adp
    • -1
    • +1
    ./portrait/comment-edit.adp
    • -1
    • +1
    ./portrait/erase.adp
    • -1
    • +1
    ./portrait/index.adp
    • -1
    • +1
    ./portrait/upload.adp
  9. … 389 more files in changeset.
Saturday 27 Jun 2015
6:47 pm

gustafn

- standardize url construction

Options
    • -3
    • +3
    ./portrait/index.tcl
  2. … 6 more files in changeset.
6:03 pm

gustafn

- standardize url construction to protect against injection attacks

Options
    • -2
    • +2
    ./portrait/erase.tcl
    • -3
    • +3
    ./portrait/upload.tcl
  3. … 55 more files in changeset.
Sunday 14 Jun 2015
1:55 am

gustafn

- use type checking for boolean parameters in page_contracts to improve security

Options
    • -2
    • +2
    ./basic-info-update.tcl
  2. … 29 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -1
    • +1
    ./basic-info-update.adp
    • -1
    • +1
    ./basic-info-update.tcl
    • -1
    • +1
    ./email-privacy-level.tcl
    • -1
    • +1
    ./password-reset.adp
    • -2
    • +2
    ./password-reset.tcl
    • -1
    • +1
    ./password-update.adp
    • -6
    • +6
    ./password-update.tcl
    • -2
    • +2
    ./portrait/comment-edit.tcl
    • -2
    • +2
    ./portrait/erase.tcl
    • -4
    • +4
    ./portrait/index.tcl
    • -2
    • +2
    ./portrait/upload.tcl
  12. … 2537 more files in changeset.
Tuesday 05 Aug 2014
11:49 am

gustafn

- check ids in page contracts

Options
    • -2
    • +2
    ./basic-info-update.tcl
    • -1
    • +1
    ./email-privacy-level.tcl
    • -2
    • +2
    ./password-reset.tcl
    • -2
    • +2
    ./password-update.tcl
    • -2
    • +2
    ./portrait/comment-edit.tcl
    • -2
    • +2
    ./portrait/erase.tcl
    • -2
    • +2
    ./portrait/index.tcl
    • -2
    • +2
    ./portrait/upload.tcl
  9. … 33 more files in changeset.
Wednesday 11 Sep 2013
8:40 pm

gustafn

- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

Options
    • -1
    • +1
    ./basic-info-update.adp
    • -1
    • +1
    ./password-reset.adp
    • -1
    • +1
    ./password-update.adp
  4. … 335 more files in changeset.
Monday 09 Sep 2013
6:44 pm

gustafn

- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

Options
    • -3
    • +3
    ./portrait/index.tcl
  2. … 121 more files in changeset.
Friday 06 Sep 2013
6:01 pm

gustafn

- replace deprecated "ad_require_permission" by "permission::require_permission"

Options
    • -2
    • +2
    ./portrait/comment-edit.tcl
    • -2
    • +2
    ./portrait/erase.tcl
    • -2
    • +2
    ./portrait/index.tcl
    • -2
    • +2
    ./portrait/upload.tcl
  5. … 65 more files in changeset.
Tuesday 27 Aug 2013
2:20 pm

gustafn

- get rid of empty_string_p in non-deprecated code

- make use of tcl byte-code compiler

Options
    • -6
    • +6
    ./password-update.tcl
  2. … 42 more files in changeset.