• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

  1. … 13 more files in changeset.
Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Streamline idiom

mprove spelling: move closer to the linux documentation recommendations, standardize variable names

  1. … 19 more files in changeset.
Use ad_page_contract, remove redundant sql

whitespace changes

  1. … 51 more files in changeset.
Remove unnecessary xql

Use more API

  1. … 2 more files in changeset.
Streamline code

remove $Id$ line

fix typo

delete unneeded .xql files

  1. … 20 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

Break long lines

  1. … 24 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 48 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 14 more files in changeset.
Reduce divergency between oracle and postgres codebase

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7824 more files in changeset.
- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

  1. … 5 more files in changeset.
- make boolean tests in .adp files more uniform

  1. … 56 more files in changeset.
Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 15 more files in changeset.
- write sql statements between curly braces

  1. … 14 more files in changeset.
.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

  1. … 22 more files in changeset.
.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

  1. … 70 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 746 more files in changeset.
- standardize argument passing to adp-includes, don't perform double i18n and double quoting

  1. … 124 more files in changeset.
- fix and standardize quoting in template properties

  1. … 42 more files in changeset.
- fix and standardize quoting in template properties

  1. … 393 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2537 more files in changeset.
- check ids in page contracts

  1. … 40 more files in changeset.
- use numeric comparison for truth values

  1. … 16 more files in changeset.