• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce divergency between oracle and postgres codebase, resolve ancient TODOs, reinstate lost query

    • -44
    • +1
    ./tcl/contract-procs-postgresql.xql
Whitespace cleanup

  1. … 2 more files in changeset.
Use ad_page_contract

  1. … 1 more file in changeset.
Bring files on oacs-5-10 in sync with HEAD

    • -70
    • +71
    ./tcl/acs-service-contract-procs.tcl
  1. … 15 more files in changeset.
Whitespace changes

    • -69
    • +68
    ./tcl/acs-service-contract-procs.tcl
Add @see and fix typo in proc doc

fix typo

reduce verbosity

add new proc "acs_sc_update_alias_wrappers" to allow refetching of wrapper functions

    • -18
    • +11
    ./tcl/acs-service-contract-init.tcl
    • -1
    • +35
    ./tcl/acs-service-contract-procs.tcl
acs_sc::impl::get_id: in case, no such implementation is available, return empty. This makes it possible to use this function to test for existance.

improve spelling

  1. … 8 more files in changeset.
Fix @param names

  1. … 1 more file in changeset.
make tested API calls explicit

    • -3
    • +11
    ./tcl/test/acs-service-contract-procs.tcl
improve spelling

  1. … 12 more files in changeset.
Avoid unnecesary existence checks

Reduce divergencies between oracle and postgres codebase

    • -48
    • +7
    ./tcl/acs-service-contract-procs-oracle.xql
    • -45
    • +6
    ./tcl/acs-service-contract-procs-postgresql.xql
    • -3
    • +19
    ./tcl/acs-service-contract-procs.tcl
    • -0
    • +19
    ./tcl/acs-service-contract-procs.xql
Fix unbalanced parenthesis

Fix proc metadata + Whitespace

improve spelling

  1. … 4 more files in changeset.
improve capitalization

  1. … 5 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
Reduce query duplication

    • -15
    • +2
    ./tcl/acs-service-contract-procs-oracle.xql
    • -16
    • +2
    ./tcl/acs-service-contract-procs-postgresql.xql
Prefer 'lappend' to 'set ... concat' for appending elements to lists + Whitespace changes

  1. … 3 more files in changeset.
regenerated documentation

  1. … 2 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 70 more files in changeset.
simplify code and make it more consistent

  1. … 5 more files in changeset.
fix typo

Fix typos

  1. … 38 more files in changeset.
fix typos

  1. … 10 more files in changeset.