acs-service-contract-procs.tcl

  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce logging as we do downstream

preserve comments hinting to ad_apply and apply whitespace changes

  1. … 2 more files in changeset.
Deprecate ad_apply, made obsolete in modern Tcl by the expansion operator "{*}"

  1. … 4 more files in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
Improve sql portability

  1. … 5 more files in changeset.
Reduce divergency between oracle and postgres codebase

  1. … 2 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

    • -70
    • +71
    ./acs-service-contract-procs.tcl
  1. … 15 more files in changeset.
Whitespace changes

    • -69
    • +68
    ./acs-service-contract-procs.tcl
Add @see and fix typo in proc doc

add new proc "acs_sc_update_alias_wrappers" to allow refetching of wrapper functions

  1. … 1 more file in changeset.
Fix @param names

  1. … 1 more file in changeset.
Reduce divergencies between oracle and postgres codebase

  1. … 3 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Reduce query duplication

  1. … 2 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Standardize spellings of names

  1. … 12 more files in changeset.
.xql-file reform of acs-service-contract

- remove sql statements from the code, where these are provided via .xql

- prefer empty sql statements over various forms of *SQL*

- remove unneeded sql queries

acs_sc::msg_type::delete.delete_by_id

-remove unneeded files

tcl/acs-service-contract-init-oracle.xql

tcl/acs-service-contract-init-postgresql.xql

www/binding-uninstall-postgresql.xql

  1. … 5 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -28
    • +26
    ./acs-service-contract-procs.tcl
  1. … 2547 more files in changeset.
- use list instead of quoted strings in util_memoize to avoid surprises with empty strings etc.

  1. … 2 more files in changeset.
- use "lassign" instead of "foreach ... break" idiom

  1. … 5 more files in changeset.
- document the non-deprecated functions, not the deprecated ones

  1. … 4 more files in changeset.
- get rid of deprecated calls to acs_sc_call in regression test

    • -20
    • +16
    ./acs-service-contract-procs.tcl
- abstract in check for existance of a command whether this is scripted or not

- use a more modern tcl command set

  1. … 12 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command "::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered the few occurances.

The fix works as well with Tcl 8.4. The proper fix for 8.5 would be to use instead of the function the expand operator {*}

  1. … 3 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
merge all the changes on the oacs-5-1 and dotlrn-2-0 branches up to tag jcd-merge-20040420

  1. … 647 more files in changeset.