• last updated 5 hours ago
Constraints: committers
Constraints: files
Constraints: dates
- update postgres function to modern style plpgsql definitions, avoid backslash escaping

- add missing function_args

    • -63
    • +110
    • -165
    • +311
    • -11
    • +20
    • -43
    • +79
    • -6
    • +26
  1. … 1 more file in changeset.
add missing function_args to stored precedures (provided by Stefan Sobernig)

    • -0
    • +74
  1. … 1 more file in changeset.
Correction of name constraint

  1. … 4 more files in changeset.
return one of the names of the unimplemented op

Remerge Timo's changes for tip 42,43, cf tip 53

    • -0
    • +207
  1. … 95 more files in changeset.
rollback of Timo's name, package_id commit; see TIP 53

    • -207
    • +0
  1. … 94 more files in changeset.
TIP#42,43: adding package_id and title to acs_objects table

    • -0
    • +207
  1. … 94 more files in changeset.
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 597 more files in changeset.
Addresses bug 1148, bug 1149 (and performance problems generally with plpgsql functions).

eliminate with(isstrict,iscachable) in favor of the new syntax strict, immutable, stable.

bump version of acs-kernel, acs-content-repository to 5.0.0b4, upgrade scripts provided.

Fix bugs with the following plpgsql procs:

acs_object__initialize_attributes: raise exception on null input.

acs_object__set_attribute: exception on null input

acs_object_util__get_object_type: remove the exception after the return statement

apm__unregister_package: properly default cascade_p

apm__unregister_service: properly default cascade_p

content_item.get_parent_folder: infinite loop on input if not a direct descendent of a folder (fixed on oracle too)

content_item__get_context: exception on null input, fix bug in exception print (wrong variable name)

content_item__is_publishable: returned t on null and invalid items

content_item__is_subclass: did not short curcuit loop when subclass found

content_item__move: would silently ignore null target_id

content_revision__copy_attributes: generate an exception on null input

content_revision__export_xml: generate exception if called (unimplemented in postgres)

content_symlink__copy: generate exception if called (unimplemented)

apm_package__parent_id: returned -1 on not found rather than null

content_folder__is_registered: no default provided in code for include_subtypes

content_keyword__is_assigned: no default for recurse...

content_revision__import_xml: generate exception if called (unimplemented in postgres)

content_revision__index_attributes: generate exception if called (unimplemented in postgres)

content_type__trigger_insert_statement: now generates exception on null input (was silent failure)

number_src: infinite loop on null input

rule_exists: fix case folded lookup

Declare the following stable:

get_func_definition get_func_header acs_message__name

acs_object_type_insert_tr acs_message__message_p

acs_object_type__pretty_name acs_message__first_ancestor

acs_object_type__is_subtype_p acs_objects_get_tree_sortkey

acs_object__name acs_object__default_name

acs_object__get_attribute_storage acs_object__get_attribute

acs_object__check_path acs_mail_link__link_p

acs_object_util__object_type_exist_p acs_object_util__get_object_type


acs_object_util__object_ancestor_type_p acs_object_util__object_type_p

acs_rel_type__role_pretty_name acs_rel_type__role_pretty_plural

party__email person__name person__first_names person__last_name


acs_user__receives_alerts_p group_contains_p

acs_message_get_tree_sortkey acs_mail_body__body_p

acs_permission__permission_p acs_mail_multipart__multipart_p

content_keyword__get_heading acs_group__name acs_group__member_p

rel_segment__get rel_segment__name rel_constraint__get_constraint_id

rel_constraint__violation rel_constraint__violation_if_removed

content_keyword__get_description site_node_get_tree_sortkey

timezone__convert_to_local timezone__get_offset

timezone__get_rawoffset timezone__get_abbrev timezone__get_date

timezone__isdst_p rdbms_date apm__register_p timezone__get_id

doc__get_proc_header apm__parameter_p apm__id_for_name apm__get_value

apm__get_value apm_package__initial_install_p apm_package__singleton_p

apm_package__num_instances apm_package__name

apm_package__highest_version apm_package__parent_id

apm_package_type__num_parameters content_keyword__is_leaf

acs_sc_msg_type__get_id acs_sc_msg_type__get_name

acs_sc_contract__get_id acs_sc_contract__get_name

acs_sc_operation__get_id acs_sc_impl__get_id acs_sc_impl__get_name

acs_sc_binding__exists_p cr_items_get_tree_sortkey

content_keyword__is_assigned content_keyword__get_path

content_template__is_template cr_keywords_get_tree_sortkey

content_template__get_path table_exists column_exists trigger_exists

trigger_func_exists rule_exists content_folder__is_registered

content_folder__get_label content_folder__get_index_page

content_type__get_template content_type__trigger_insert_statement

content_type__is_content_type content_item__get_root_folder

content_item__is_published content_item__is_publishable

content_item__is_valid_child content_item__get_id

content_item__get_template content_item__get_content_type

content_item__get_live_revision content_item__get_revision_count

content_item__get_context content_item__get_latest_revision

content_item__get_best_revision content_item__get_title

content_item__get_title content_item__get_publish_date

content_item__is_subclass content_item__is_index_page

content_item__get_parent_folder content_revision__get_number

content_revision__revision_name content_revision__is_latest

content_revision__get_content content_symlink__is_symlink

content_symlink__resolve_content_type content_extlink__is_extlink

content_folder__is_folder content_folder__is_empty

file_storage__get_root_folder file_storage__get_package_id

forums_message__root_message_id content_symlink__resolve

  1. … 41 more files in changeset.
Deleted too mcuh

- Default impl_pretty_name to impl_name

- Include impl_owner_name and impl_pretty_name in views

- Clean up UI and make it use list builder

  1. … 12 more files in changeset.
Fixed unterminated string in acs_sc_impl__new, and untabified the entire file

    • -110
    • +113
the three argument acs_sc_impl__new function was previously removed but it's used in more than 50 places in the code. Adding it back

adding upgrades scripts for pretty_names on acs sc impls

    • -0
    • +45
  1. … 1 more file in changeset.
added support for pretty_names to acs sc impls

  1. … 8 more files in changeset.
merge of 4.6.3b1 to HEAD

  1. … 107 more files in changeset.
A bunch of things

1. AOLserver 4.0's nsxml appears to expose a gcc bug which causes the

backwards-compatible "getattr" command to fail. I dug around nsxml

and it does appear to be a gcc bug. I changed to the proper nsxml v2


2. In the course of exploring #1 above, I realized that the calls to

dom:: Tcl XML package commands were still being executed despite

being commented out. Typical Tcl misunderstanding on someone's part.

Net effect: we were parsing all APM .info files twice, once in Tcl

and once in ns_xml! Yuk!

3. Fixed a minor notifications bug - you couldn't delete a notification

request if any unsent notifications were pending, causing the homework

package to bomb if you deleted an uploaded homework file and the prof

hadn't yet received their notification.

4. Fixed an obscure corner case in my permissions denormalization code.

  1. … 15 more files in changeset.
merge from oacs-4-6

  1. … 110 more files in changeset.
file upgrade-4.5.1-4.6.sql was initially added on branch oacs-4-6.

    • -0
    • +0
  1. … 3 more files in changeset.
- Upgrade scripts for acs-content-repository, acs-events, acs-kernel, acs-mail, acs-service-contract, bookmarks, faq, file-storage, news and search

- Bumped version of above packages to 4.6

- Fixed the view/sequence hack in apm-create so that APM package edit UI works in PG 7.2

  1. … 30 more files in changeset.
Improved the error message when a binding fails

Applied patch submitted by Dave Bauer - acs_sc_impl_alias__delete was missing

a parameter.

Cast arguments to acs_sc_binding__new to make sure integer version is

selected. Add error checking to text version.

  1. … 1 more file in changeset.
added float and bytearray message types

  1. … 1 more file in changeset.
naming convention changes

naming conventions

  1. … 3 more files in changeset.
changed to comply with naming conventions

Adding it in ...

    • -0
    • +253
    • -0
    • +12
    • -0
    • +42
    • -0
    • +9
    • -0
    • +484
    • -0
    • +20
    • -0
    • +99
    • -0
    • +5
    • -0
    • +46
    • -0
    • +3
    • -0
    • +5
    • -0
    • +5
    • -0
    • +87
    • -0
    • +16
  1. … 8 more files in changeset.