• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

Reduce number of queries, improve documentation

Queries could be made even less e.g. by locking and querying the tuples in one statement. However, it would be trickyer to make the code portable.

Simplify nsv idiom

Simplify documentation

Fix typo in doc

Fixes for Oracle 19c: replaced "limit" by the portable idiom "fetch ... rows only"

This fixes the following bug in Oracle installations:

: SQL:

: select aml_email_id from acs_mail_lite_from_external

: where processed_p <>'1'

: and release_p <>'1'

: order by priority

: !>>>!limit :email_max_ct

: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00933: SQL command not properly ended

Deprecate util_ns_set_to_list: ns_set array is an equivalent oneliner

  1. … 4 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
fix for issue #3463

Many thanks to Tony Kirkham for the fix!

Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p'

Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private.

reduce public footprint

replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path

  1. … 7 more files in changeset.
Deprecate acs_mail_lite::message_interpolate in favor of 'string map'

Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

mark functions called only internally as private

  1. … 12 more files in changeset.
improve listing of test coverage

  1. … 8 more files in changeset.
Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case

make listing of tested procs more complete

  1. … 6 more files in changeset.
Handle to_addr specified as "DisplayName <email>": keep the display name in the header value and strip it in the RCPT TO

make end of options explicit

  1. … 41 more files in changeset.
Fix typos

Fix priority check in 'acs_mail_lite_inbound_procs_check' test case

warn about unexpected entries (typos) in EmailDeliveryMode

Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd.

According to the RFC:

- "Before sending a line of mail text, the SMTP client checks the

first character of the line. If it is a period, one additional period is inserted at

the beginning of the line."

- "When a line of mail text is received by the SMTP server, it checks the line. If the

line is composed of a single period, it is treated as the end of mail indicator. If

the first character is a period and there are other characters on the line, the first

character is deleted."

This change adds the second period at the beginning of a line suggested in the first

paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one.

In the case of lines comprised of just a single period, '::mime::qp_encode' already takes

care of them by converting the '.' into '=2E', so they are not affected by this.

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 57 more files in changeset.
Use only 100 objects for the test, as in large instances this can take several minutes

Improve sql portability