• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
make lang::conn::language able to run running disconnected; improve documentation

bump version number to 5.10.0d8

make lang::conn::locale more robust when running disconnected

Whitespace cleanup

    • -12
    • +12
    ./tcl/localization-procs-oracle.xql
    • -10
    • +9
    ./tcl/localization-procs-postgresql.xql
Delete leftover page from the old good days:

- it is supposed to test the localization data model, but columns are wrong, so it probably refers to an older version

- similar tests already take place in the appropriate acs-automated-tests framework, so makes little point to fix it or port it

- makes use of deprecated api (e.g. ad_footer)

improve page contracts

improve page_contracts

    • -6
    • +6
    ./www/admin/edit-localized-message.tcl
    • -1
    • +1
    ./www/admin/export-locale-to-files.tcl
    • -2
    • +2
    ./www/admin/import-locale-from-files.tcl
    • -2
    • +2
    ./www/admin/message-conflict-resolve.tcl
    • -2
    • +2
    ./www/admin/message-conflict-revert.tcl
  1. … 6 more files in changeset.
Use ad_page_contract

  1. … 1 more file in changeset.
Use ad_include_contract

  1. … 1 more file in changeset.
Add remark: this file seems to be a leftover from the old good days

Use ad_include_contract

    • -6
    • +11
    ./www/admin/message-usage-include.tcl
Whitespace cleanup

Use ad_include_contract

Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

  1. … 11 more files in changeset.
Fix typo

Doc formatting changes

Keep supporting previously undocumented use cases for lc_time_fmt:

- database timestamps e.g. "2019-12-16 12:58:10.370124+01"

- short timestamps without seconds e.g. "2019-12-16 12:58"

Improved documentation and extended test cases

    • -1
    • +32
    ./tcl/test/acs-lang-localization-procs.tcl
Address lc_time_fmt shortcomings:

- use clock scan to enforce supported date formats, 'YYYY-MM-DD' (undocumented, but explicitly checked for in the code) and 'YYYY-MM-DD HH:MM:SS'

- leverage clock scan capabilities to correctly handle 'impossible dates' such as 1999-02-29

- leverage clock format to obtain the correct week day

- leverage clock api to correctly handle gregorian/julian dates

- implement documented formats that had an empty entry in format array (%W, u, %U, %j)

Deprecated get_referrer and NsSettoTclString, replace them with versions that respect OpenACS naming convention

  1. … 7 more files in changeset.
Provide convenience link to default locale (resolves issue #3430)

    • -1
    • +3
    ./www/admin/edit-localized-message.tcl
fix for issue # 3429

    • -3
    • +3
    ./www/admin/edit-localized-message.tcl
Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

  1. … 7 more files in changeset.
Rename clock_to_ansi to lc_clock_to_ansi to comply with naming convention, replace occurrences, create deprecated wrapper

  1. … 5 more files in changeset.
Fixed typo in message-key. Bump acs-lang version to reload message keys.

    • -1
    • +1
    ./catalog/acs-lang.de_DE.ISO-8859-1.xml
Trailing whitespace cleanup

Code cleanup: use "ad_form" for form processing and "ad_include_contract"; dropped support for "change-locale-include"-include attribute "return_p" as it was never used in the include's code.

    • -122
    • +94
    ./www/change-locale-include.tcl
move test cases for lc_monetary_currency to acs-outdated, where the definition lives

  1. … 2 more files in changeset.
use existing api

validate user_locale

improve handling of invalid (hacked) ad_locale cookies.

Previously, invalid ad_locale cookies lead to an error, which in turn

prevented all communication with OpenACS. So, a user had to delete the

cookie manually. Now, we just produce a warning, ignore and delete such

broken cookies.