• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace cleanup

Use ad_include_contract

Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

  1. … 11 more files in changeset.
Fix typo

Doc formatting changes

Keep supporting previously undocumented use cases for lc_time_fmt:

- database timestamps e.g. "2019-12-16 12:58:10.370124+01"

- short timestamps without seconds e.g. "2019-12-16 12:58"

Improved documentation and extended test cases

    • -1
    • +32
    ./tcl/test/acs-lang-localization-procs.tcl
Address lc_time_fmt shortcomings:

- use clock scan to enforce supported date formats, 'YYYY-MM-DD' (undocumented, but explicitly checked for in the code) and 'YYYY-MM-DD HH:MM:SS'

- leverage clock scan capabilities to correctly handle 'impossible dates' such as 1999-02-29

- leverage clock format to obtain the correct week day

- leverage clock api to correctly handle gregorian/julian dates

- implement documented formats that had an empty entry in format array (%W, u, %U, %j)

Deprecated get_referrer and NsSettoTclString, replace them with versions that respect OpenACS naming convention

  1. … 7 more files in changeset.
Provide convenience link to default locale (resolves issue #3430)

    • -1
    • +3
    ./www/admin/edit-localized-message.tcl
fix for issue # 3429

    • -3
    • +3
    ./www/admin/edit-localized-message.tcl
Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

  1. … 7 more files in changeset.
Rename clock_to_ansi to lc_clock_to_ansi to comply with naming convention, replace occurrences, create deprecated wrapper

  1. … 5 more files in changeset.
Fixed typo in message-key. Bump acs-lang version to reload message keys.

    • -1
    • +1
    ./catalog/acs-lang.de_DE.ISO-8859-1.xml
Trailing whitespace cleanup

Code cleanup: use "ad_form" for form processing and "ad_include_contract"; dropped support for "change-locale-include"-include attribute "return_p" as it was never used in the include's code.

    • -122
    • +94
    ./www/change-locale-include.tcl
move test cases for lc_monetary_currency to acs-outdated, where the definition lives

  1. … 2 more files in changeset.
use existing api

validate user_locale

improve handling of invalid (hacked) ad_locale cookies.

Previously, invalid ad_locale cookies lead to an error, which in turn

prevented all communication with OpenACS. So, a user had to delete the

cookie manually. Now, we just produce a warning, ignore and delete such

broken cookies.

improve spelling

Delete obsolete UI

Use 'ns_log Error' for error logging, instead of 'ns_log Notice: Error...'

  1. … 4 more files in changeset.
Fix typo

Do not rely on error trapping for file retrieval, introduce a test for this proc

improve spelling

  1. … 12 more files in changeset.
improve spelling

  1. … 7 more files in changeset.
Trailing whitespace cleanup

Prefer '==' over 'eq' on numeric comparison

  1. … 2 more files in changeset.
Prefer '==' over 'eq' on numeric comparison

lc_content_size_pretty: go the extra mile and return a localized 'byte' when the result is just 1 byte. Bump acs-lang version to reload message keys.

    • -0
    • +1
    ./catalog/acs-lang.ast_ES.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.ca_ES.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.da_DK.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.en_AU.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/acs-lang.en_GB.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.es_CO.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.es_ES.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.es_GT.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.eu_ES.ISO-8859-1.xml
  1. … 20 more files in changeset.