• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset oacs-5-10%3Aantoniop%3A20190325141636 does not exist.

removed the previous half finished change, the update of the timezone data helps

fix regression test to cope with time zone

Since OpenACS timezone data is now newer as in many tcl versions, some time zones

might not be available in tcl. Therefore, tcl-based conversions with these

time zones will fail.

This change skips these timezones (on my system, 2 cases). But this

is just a part of the fix. The "DB-based conversion" in "lc_time_tz_convert"

seems to be broken for these cases as well, otherwise the regression

test would not have stopped working.

Adapt test to current timezones

Extend test suite to check that also dates in the "short" time format are supported

This test will fail

Test external command line dependencies

  1. … 1 more file in changeset.
Complete coverage for the package

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lang-widget-procs.tcl
Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Replace api outside of the package dependencies

Increase coverage

This test will currently fail because the translator mode flag is cached per thread, but the set api won't update this cache.

Increase proc coverage

Increase proc coverage

Re-load also all other enabled locales to avoid test side effects

Increase proc coverage

Wrap test in a transaction

file lang-util-procs.tcl was initially added on branch oacs-5-10.

Increase proc coverage

Improve coverage

Increase proc coverage

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

  1. … 5 more files in changeset.
Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

file locale-procs.tcl was initially added on branch oacs-5-10.

Increase proc coverage

Increase proc coverage

file lang-catalog-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lang-catalog-procs.tcl
Cleanup leftover, fix typos

Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

    • -0
    • +118
    ./acs-lang-localization-procs.tcl
improve spelling

  1. … 9 more files in changeset.
Return 0 when looking up the existance of a message key in an unsupported locale instead of failing, test the behavior

  1. … 1 more file in changeset.
Improve test precision: take into account packages defined as <install... in the info file, as e.g. dotlrn does