lang-message-procs.tcl

  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Mark 'lang::message::cache' as public, as it is used in 'acs-admin'

Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
remove protection "private", since function has to be called from other packages

  1. … 6 more files in changeset.
bring test coverage to >50% by adding test cases and marking only locally called functions as private

  1. … 2 more files in changeset.
mark unused function "_mr" as deprecated

Define arguments so that documentation__check_parameters automated test does find -varname flag correctly

Fix typo

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

  1. … 1 more file in changeset.
acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

  1. … 9 more files in changeset.
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 18 more files in changeset.
avoid repeated lookup for the same locale

- simplifying one more expression

- bump version number to 5.10.0d11

  1. … 1 more file in changeset.
reduced the number of mutex locks for message keys lookup by a factor of two by using naviserver commands

improve spelling

  1. … 11 more files in changeset.
Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

Switch to a sql-only approach (fixes regression)

Replace ad_decode idioms

Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Whitespace changes + editor hints

  1. … 19 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
don't load deleted messages into the cache and drop conceptually broken parameter

  1. … 1 more file in changeset.
Fix typo

Replace silent catch with something nicer

Fulfill Lars old dream by using a thread safe idiom

Remove private proc 'lang::message::translate', broken since 2002 and used nowhere.

Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
improve spelling

  1. … 11 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.