• last updated 18 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Cleanup of acs_object_context_index' and friends in creation scripts

This change completes the commit [1] from 2019, where the cleanup was performed

acs_object_context_index and its maintenance functions just as an update script.

This change addresses this also in the creation scripts and in packages, still

depending on the old functions.

[1] https://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Ahectorr%3A20190708160122

  1. … 9 more files in changeset.
added constraint acs_objects_context_id_ck to avoid certain simple loops on context_ids

  1. … 2 more files in changeset.
Index acs_object's creation and modification date

  1. … 2 more files in changeset.
Define an acs_object schema and use it to redefine acs_object__name using dot notation

Goal is to further reduce code divergency between Oracle and Postgres

  1. … 2 more files in changeset.
improve spelling

  1. … 33 more files in changeset.
implementing feature request #3408: support for passing in null values to acs_object__set_attribute

  1. … 2 more files in changeset.
Fix typos

  1. … 31 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

  1. … 16 more files in changeset.
Fix typos

  1. … 12 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Fix spelling errors

  1. … 48 more files in changeset.
- use dollar quoting for SQL comments

  1. … 1 more file in changeset.
Remove type discrepancy introduced in 2002:

- acs_object_types.object_type has type varchar(1000), while

- acs_object_types.supertype has type varchar(100)

... several more data types are involved, using acs_object_types.object_type as foreign key

  1. … 5 more files in changeset.
- fix install scripts

  1. … 1 more file in changeset.
- second part of Part 4 of OpenACS 5.9 agenda: get rid of tree_sortkey in acs-objects : getting rid of functions accessing acs_objects.tree_sortkey when creating new instances

- use variable names "ot1" and "ot2" instead of "o1" and "o2" when referring to object_types (and not objects)

  1. … 1 more file in changeset.
- scalability reform part 1

* remove manual delete operations from acs_object__delete()

where update is as achieved automatcially via cascade operations

* improve documentation of source code

- bump version number to 5.9.0d2

  1. … 2 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- fixing 2 more cases of still incorrect function argument names

  1. … 3 more files in changeset.
- fix function args: names of arguments for postgres did not match names for oracle leading to potential portability problems

  1. … 1 more file in changeset.
Bring PostgreSQL functions closer to the current level of PL/pgSQL:

- upgrade PL/pgSQL functions to the $$ notation (recommended since pg8.0, jan 2005).

- get rid of backslash usages in function definitions

- drop aliases in favor of named function arguments (recommended since pg8.0)

- fix wrong function_args, add missing function_args, align default semantics

with the defaults in pg (providing "null" as default means the argument is


- change return types of triggers from "opaque" to "trigger" (recommended since pg8.0)

- unify names of triggers *_tr

- removed some version dependencies of pg 7.2 and 7.3

  1. … 54 more files in changeset.
Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

  1. … 214 more files in changeset.
Changes for supporting postgresql 9.0:

- Avoiding usage of SQL reserved keywords on plpsql functions (plpsql lexer and parser were reworked).

- Fixing all those places on which FROM clause was automatically added by PG ( PG Config add_missing_from parameter was removed for this release of PG ).

Many thanks to Tracy Adams and Jeff Lu for providing first version of the patches.

  1. … 16 more files in changeset.
Somebody hosed this (probably me). Never caught because no one creates a

base object directly, just subtypes of acs_object with their own (correct)

definition of a new() function.

- complete change to acs_objects_package_idx for new creates (see http://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-6%3Agustafn%3A20100509112929)

  1. … 1 more file in changeset.
1. Changed trigger functions from "opaque" to "trigger" to get rid of the

warnings during initial install (only for acs-kernel, there are a lot


2. Added "embeds" for postgresql and partially for oracle.

3. Added global parameters for postgresql and partially for oracle.

(oracle will be forthcoming shortly)

  1. … 29 more files in changeset.
Added some missing attributes (more to go, though, damn core datamodel)

  1. … 3 more files in changeset.
Someone didn't realize that "foo;null" in define_function_args calls sets the

default value to 'null' not NULL...this has been there a long time ... maybe

even my fault, but I don't remember, it's ancient!

  1. … 1 more file in changeset.
- Add two missing indices to improve performance of permission system

and the object context hierarchy significantly (these two indices

improved the performance of e.g. /projects/openacs/download/ and

/projects/openacs/download/one-revision?revision_id=2089636 by more

than a factor of 10; these indices are now among the most used on


- Bump version number

  1. … 5 more files in changeset.
Get rid of the postgres warning "adding missing FROM-clause entry " on sequences

Make "db_nextval acs_object_id_seq" more than twice as fast (from 948 microseconds to 378 microseconds)

  1. … 9 more files in changeset.
adding missing function args, fixing incorrect function args, including upgrade script

  1. … 3 more files in changeset.