acs-bootstrap-installer

  • last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
mark functions called only internally as private

  1. … 15 more files in changeset.
just avoid tilde substitution, do not perform sanitizing

sanitizing can lead to file name clashes in case the names

without tilde exists, and they are OS specific. The intention

of "ad_file" is just to be a tilde-proof "file" replacement

Sanitize all trailing tildes from the filename, mapping them to the current folder

Fixes acs-bootstrap-installer.ad_file automated test

Make 'ad_file' test case deterministic

Automated test for ad_file exposing a blind spot with files starting with the '~' character

file 00-proc-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/00-proc-procs.tcl
improve spelling

    • -10
    • +12
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
allow value checkers in ad_procs

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

    • -4
    • +4
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 53 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 3 more files in changeset.
Treat callback hooks and implementations as private api

Reduce acs-tcl.documentation__check_deprecated_see test warnings

  1. … 2 more files in changeset.
introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

    • -2
    • +2
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 44 more files in changeset.
deprecate unused function

improve loading times and blueprint size, when acs-automated testing is deactivated

For details, see: https://openacs.org/forums/message-view?message_id=5452350

CVS: ----------------------------------------------------------------------

  1. … 1 more file in changeset.
added missing editor hints

    • -1
    • +7
    ./installer/www/SYSTEM/csp-collector.tcl
  1. … 20 more files in changeset.
Restrict switches to not negative Tcl numbers, and avoid non-printable characters as well

Whitespace changes

Rename the private proc 'bootstrap_fatal_error' to 'acs_bootstrap_fatal_error', to comply with OpenACS naming standards

Fix typo

address issue #3435 (many thanks to Michael Aram)

  1. … 1 more file in changeset.
Remove private proc 'number_p', used only in 'ad_proc_valid_switch_p', and simplify logic of the latter

Add ad_page_contract

    • -0
    • +5
    ./installer/www/SYSTEM/csp-collector.tcl
improve spelling: prefer comma after "therefore" and friends

  1. … 2 more files in changeset.
moved "populate_secrect" to "sec_*" prefix to reduce clobbering of global namespace

  1. … 5 more files in changeset.
Fixed bug while populating the 'api_proc_doc_scripts' nsv on ad_proc, where some procs where not added due to a race condition between the 'acs-automated-testing' and the 'acs-bootstrap-installer' packages. See comments in commit for more details.

improve spelling

    • -2
    • +2
    ./tcl/40-db-query-dispatcher-procs.tcl
reduce warnings from Chrome audits

  1. … 2 more files in changeset.
Deprecate trivial empty_string_p

improve spelling