• last updated 22 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- revert escaped change, add change to make clear that we do not want to accept empty strings

- make clear that we do not want to accept empty strings

- perform better input checking on action and categories

- perform better checking on page number

    • -2
    • +2
    /openacs-4/packages/news/www/index.tcl
- better checking on page number

- better checking on version_id

- improve error messages (backport from openacs.org)

- renew the session_id after privilege level change from unidentified to identified user

- change ad_instproc to instproc for new validate=form_input_fields

- add validator hook validate=form_input_fields to ease testing of inter-dependencies of form-fields on a form page

New feature: now one can send plain filesystem files as email attachments, instead than only those into file-storage

file upgrade-5.8.1d3-5.8.1d4.sql was initially added on branch oacs-5-8.

- include pid of child process as well in error message

- with_finally: include exit code in error message in case we have a CHILDSTATUS error

- improve linebreaks in error log when loading files (no need to restrict to 70 cols)

- use list instead of quoted strings in util_memoize to avoid surprises with empty strings etc.

- use quoting more consistently

- use more safe version comparison

- added an option flag "ignore_missing_package_ids" to xo::db::Class ad_instproc instantiate_objects to

omit warnings about missing package_ids for parameters. Currently, OpenACS creates apm_paramter

objects without a package_id. This is not so easy to fix in the kernel, since e.g. the

package_id of acs-kernel is created after the paramters are added. One could use an

"magic object id", but that would need special handling on several places.

Provide a more useful error message when something fails in the transaction

Fix lc_time_fmt_compile

- use call-by-reference rather than call by value for passing values to included subtemplates (should be done probably on many more places)

    • -4
    • +4
    /openacs-4/packages/forums/www/message-post.adp
    • -1
    • +1
    /openacs-4/packages/forums/www/message-view.adp
- use call-by-reference rather than call by value for passing values to included subtemplates (should be done probably on many more places)

    • -1
    • +1
    /openacs-4/packages/forums/www/user-history.adp
- fix for bug #3224

Removed duplicate parameter

Added '::xo::library doc' to avoid loop

Added ::xo::library doc, as the server otherwise runs into a "sourcing loop",

when the file is 'xo::library require'd by another package/file...

Fixed second typo in SQL condition for publish_status

Fixed typo in SQL condition for publish_status

Fixed proc cr_create_content_file_from_string

Because of an earlier copy/paste mistake:

* variable $dir was not set (replaced with cr_fs_path)

* rearranged blocks, so that $content_file is already set

- white space change to follow coding conventions