OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 145
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 20 Oct 2019
2:52 pm

gustafn

- Fix a tricky Tcl_Obj sharing bug triggered by the usage of C-level

IndexObjs based on volatile tables. Consider the following example:

proc foo {x} {

return [bar -value x ...]

}

The Tcl_Obj "x" is shared as name of argument and as a value of the

non-positional parameter "-value". When bar (e.g. C-implemented)

uses Tcl_GetIndexFromObj*() to lookup "x" in a table of options,

which is volatile, the involved Tcl_Obj will be converted to an

indexObj.

On a call with wrong number of arguments( e.g."foo 1 2 3"), Tcl

will try to give a nice error message, saying that "foo x" can be

called only with one argument. When printing argument "x", it sees

that "x" is an indexObj, and for these kinds of objects, "x" might

be an abbreviated version of a full name. Since the table behind

the indexObj is in the case above volatile, a crash might happen.

The committed fix above is just a temporary measure. NaviServer should

try to avoid such Tcl_Obj conversions in these cases. It is also

questionable, whether the attempt to interpret a argument name as

an abbreviated.

Options
    • -6
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl
Saturday 19 Oct 2019
1:53 pm

gustafn

deactivate html hacking (replace textarea by "p") since rendering is

broken due to bootstrap's "form-control" class

Options
    • -2
    • +2
    /openacs-4/packages/xowf/lib/online-exam.wf
Friday 18 Oct 2019
6:41 pm

gustafn

strip white space

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
6:37 pm

gernst

Make page for managing the parameter "PrivateEmailLevelP" subsite aware.

Options
    • -9
    • +7
    /openacs-4/packages/acs-subsite/www/admin/manage-email-privacy.tcl
6:28 pm

gustafn

allow empty correct_when specifications

Options
    • -5
    • +4
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
6:07 pm

antoniop

Whitespace cleanup

Options
    • -14
    • +13
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl
3:56 pm

gernst

Use already existing message-key.

Options
    • -1
    • +1
    /openacs-4/packages/notifications/www/admin/index.adp
3:53 pm

trenner

ensure that every formfield is disabled in the disabled_fc list (e.g. mc-interaction)

Options
    • -1
    • +2
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
3:15 pm

antoniop

Export message keys to normalize sorting anx xml quoting (will prevent huge diffs with new message keys)

Options
    • -87
    • +86
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
    • -88
    • +89
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.en_US.ISO-8859-1.xml
3:12 pm

gernst

Fixed typo in message-key. Bump acs-lang version to reload message keys.

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
    • -1
    • +1
    /openacs-4/packages/acs-lang/catalog/acs-lang.de_DE.ISO-8859-1.xml
10:35 am

gustafn

reduce verbosity

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:31 am

gustafn

use new form-field type "correct_when"

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:30 am

gustafn

provide new form-field "correct_when" for conveniant user interaction

the form-field type is currently just a text field with a tailored

help text, but can be extended in the future via pull-downs etc.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +4
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
    • -4
    • +24
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
9:20 am

gustafn

use ad_return_complaint for invalid query parameter parsing (at least in connection threads)

Options
    • -2
    • +12
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
Thursday 17 Oct 2019
9:48 pm

gustafn

fix workflow such these work as well with shared workflow definitons

Options
    • -26
    • +26
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
    • -38
    • +44
    /openacs-4/packages/xowf/lib/online-exam.wf
4:13 pm

antoniop

New test for json and utf-8 encoding against Postman Echo webservice (https://docs.postman-echo.com)

Options
    • -0
    • +93
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
Wednesday 16 Oct 2019
2:27 pm

gernst

Remove unused variable

Options
    • -3
    • +1
    /openacs-4/packages/dotlrn/www/help/help-master.tcl
1:41 pm

trenner

provide missing args for references call

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
12:33 pm

gernst

Use template::util::tcl_to_sql_list for proper list element quoting

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.xql
12:24 pm

gustafn

impreve robustness of ad_doc parsing

Options
    • -2
    • +6
    /openacs-4/packages/xotcl-core/www/show-object.tcl
11:54 am

gernst

ns_quotehtml user submitted value inside an error message to prevent potential XSS attack

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
11:42 am

gernst

Fix incorrect proc name

Options
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
Tuesday 15 Oct 2019
11:41 pm

gustafn

- overhaul of online-exam:

- support for new question types

* text_interaction

* text_entry_interaction

* mc interacotpm

- support for autocorrection feedback in print-out (first version)

based on "correct_when" (this is per tield-type, also extensible)

currently 9 types of predicates, "btwn" (heißt "zwischen"),

eq, ne, gt, ge, lt, le, match, in

- fully internationlaized

- todo:

* better support for mc,

* submission certificates for students (comtaining a digest)

* percentage grading

* export for potential post-processing of results

* improved styling

Options
    • -121
    • +253
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
    • -159
    • +214
    /openacs-4/packages/xowf/lib/online-exam.wf
11:29 pm

gustafn

- improved source code documentation

- improved checking, when ID or object is returned

Options
    • -27
    • +57
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:24 pm

gustafn

- new interaction type text_entry_interaction (abbreviated as "te" in test_item question_type)

create multipe text interactions

- added autocorrection via "correct_when" to text interaction and text_entry_interaction

- improved source code documentation

- break overlong lines

- removed usages of :instvar

- still TODO: base mc question on complex formfile types rather than HTML primitives,

since this allows better adoption to different rendering styles and better feedback modes

Options
    • -81
    • +249
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
11:13 pm

gustafn

extend message catalog

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +30
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +31
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
11:12 pm

gustafn

prefer resolver variables over method calls.

Options
    • -20
    • +29
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
11:36 am

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/download/www/doc/requirements.adp
    • -2
    • +2
    /openacs-4/packages/download/www/doc/requirements.html
11:30 am

gustafn

remove obsolete calls (ad_quotehtml) and make code more robust

Options
    • -4
    • +13
    /openacs-4/packages/download/tcl/download-procs.tcl
9:13 am

gustafn

fix for issue #3427

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl