• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add ad_page_contract, improve contract

    • -0
    • +2
    /openacs-4/packages/xowiki/www/portlet-ajax.tcl
Use ad_page_contract

    • -2
    • +11
    /openacs-4/packages/xowiki/www/admin/test.tcl
    • -2
    • +7
    /openacs-4/packages/xowiki/www/portlet-ajax.tcl
Extend automated test to include also '::xowiki::Package initialize -ad_doc' idiom as a possible way to define a page contract

This has the limitation that the idiom is searched as-is... but works for upstream code

Whitespace cleanup

Use ad_include_contract

    • -4
    • +9
    /openacs-4/packages/xowiki/lib/view.tcl
Replace deprecated idiom

Avoid sending potentially unquoted text via hidden form field

address issue #3433: add option "noquote" for the "inform" widget type

The flag is currently ignored for all other widget types

use same spelling for "i.e." as everywhere else

capitalize SQL

switch back to previous version (change of Antonio was due to some local changes)

Use ad_include_contract

Whitespace cleanup

Use ad_page_contract

Add ad_page_contract

Whitespace cleanup

Use ad_page_contract

Use ad_include_contract

Add remark: this file seems to be a leftover from the old good days

Use ad_include_contract

Whitespace cleanup

Use ad_include_contract

    • -16
    • +6
    /openacs-4/packages/acs-lang/lib/conflict-link.tcl
Use www- prefix for web callable methods to avoid warnings

Replace deprecated idiom

Fix flag in proc definition

Rename template_tag proc to comply with OpenACS naming convention, create deprecated wrapper, massage variable juggling (use an absolutely namespaced variable instead of a namespace-sensitive one)

Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

Whitespace cleanup

Whitespace cleanup

Rename get_survey_info, survey_answer_summary_display, survey_copy, survey_decode_boolean_answer, survey_display_types, survey_do_notifications, survey_get_score, survey_question_copy and survey_question_display to comply with OpenACS naming convention (all brought to the survey:: namespace), create deprecated wrappers, replace occurrences

    • -22
    • +140
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -24
    • +24
    /openacs-4/packages/survey/tcl/survey-procs.xql
    • -4
    • +4
    /openacs-4/packages/survey/www/admin/one.tcl
  1. … 22 more files in changeset.