• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fiy typo

Fix conditional expression. A typo in the original code survived succesive refactoring which made it not so obvious...

Fix caching bug detected by Hani Gadllah

revert escaped change

*** empty log message ***

Fix variable existence test, as we are initially dealing with the variable name, not the value.

note an idea such it is not forgotten

prefer XOTcl2 idioms

    • -9
    • +9
    /openacs-4/packages/xowf/tcl/atjob-procs.tcl
    • -67
    • +67
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
use :object directly, when possible

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
use :obejct directly, when possible

prefer XOTcl2 idioms

reduce verbosity

Prefer 'in' and 'ni' operators over lsearch for testing list containment

Fix capitalization

Remove extra line

Prefer 'in' and 'ni' operators over lsearch for testing list containment

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Whitespace changes

Whitespace changes

Fix typo

Rework conditional expressions

reduce verbosity

perfer variable resolver over method invocation

    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
prefer XOTcl2 idioms

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -11
    • +11
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/www/admin/test.tcl
prefer XOTcl2 idioms also in commented-out statements

    • -26
    • +26
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -110
    • +110
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -17
    • +17
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -88
    • +88
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
perfer variable resover over method invocation

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
handle ns_returnnotice via reply_to_user

add comment

    • -1
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl