• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
file animation-min.js was initially added on branch oacs-5-10.

file skin.css was initially added on branch oacs-5-10.

file grids.css was initially added on branch oacs-5-10.

file fonts-min.css was initially added on branch oacs-5-10.

file event-min.js was initially added on branch oacs-5-10.

file datatable.css was initially added on branch oacs-5-10.

file datatable-min.js was initially added on branch oacs-5-10.

Upgrade to jQuery UI 1.13.1

make grading dialog draggable

Fix acs-lang.test_message_register automated test:

when checking if a message should be created or updated, do not trust the nsv, which won't be there for messages that have been soft-deleted and go to the db instead. When a message is soft deleted, cleanup the nsv cache.

Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Test content::item::copy

make parameter name more self-expanatory to avoid misinterpretations

    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -2
    • +2
    /openacs-4/packages/xowf/lib/online-exam.wf
    • -11
    • +11
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
user forwarder for answer manager AM similar to the question manager QM

    • -33
    • +30
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Store statistics in a separate page instead of the workflow itself

- advantages:

* smaller workflow instance

- no danger that page is too large for caching, even for large exams.

- smaller objects mean also better performance

* modification date in exam is not modified when statistics

are updated

* easier extensible

- New function WorkflowPage->childpage

easy to use interface for creating child pages

- render_submission=exam_protocol: changed name of

parameter "-form_objs" to "-filter_form_ids", since

form_objs are used typically to keep objects, not ids

- Still to do: policy for inclass-exam-statistics.wf

- Bumped version number to 5.10.1d25

    • -8
    • +12
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -40
    • +113
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -8
    • +55
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
file inclass-exam-statistics.wf.page was initially added on branch oacs-5-10.

Updated inferface for Page->create_form_page_instance

Since "create_form_page_instance" creates always a form

page, we can also pass the state at creation to it

(like other essential parameters). The default value

is "initial" (the default state in workflows).

Bumped version number to 5.10.1d15

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
updated list of tested functions

Fix comment

Simplify test logics, bring comment closer to relevant code

make calculation of [ns_set array [ns_getform]] more robust

in case, invalid UTF-8 is passed in, [ns_getform] might be empty.

probably this could also be addressed in NaviServer

    • -5
    • +8
    /openacs-4/packages/xowf/www/index.vuh
improve styling of horizonal form fields (many thanks to Monika Andergassen)

Improve robustness of xowf.create_test_items automated test: make sure that the exercise appearing is actually supposed to render 2 images

Fixes xowf.create_test_items automated test

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Fix typo

Fix tag

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

refactor code

    • -20
    • +44
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -35
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Make creation of ::xo::cc more robust

In case the argument processing of

ConnectionContext create ::xo::cc -p1 ... -p2 ....

::xo::cc destroy_on_cleanup

runs into an exception leading to an ad_script_abort, the half-in

initialized object without cleanup definition will survive. At later

times, this object might be reused, containing potentially

cached results from earlier runs, which can cause troubles in error

cases.

This change takes care that errors during argument processing will

not leave half-initialized objects behind.

improve wording in comments