• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
bump version number to 5.10.0d23

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
parameter::get_from_package_key: check as well in "global" package parameter

and make clear, that lookup from non-singleton packages does not make

sense.

fix typos

improve comments, make function private to avoid confusions

improve comment

Make sure variable is an array

no need to call private function

follow usual naming conventions

    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
no need to call private function of other package

Ease usage of util_memoize during startup. let util_memoize succeed,

even when the cache is not yet created

use separate urlspace for site-node cache to reduce lock contention

prefer inline SQL over generic xql to make apm code usable during initialization

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

new parameter "fallback_languages":

Specify space delimited two character codes for checking default languages. When this parameter is non-empty, try to get the page in the specified languages as fallback rather than offering a link for creation of a page in the requested locale. Per default this paramter is empty.

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +10
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

Fix typo (thanks to Thomas Renner)

reduce redirects

    • -3
    • +3
    /openacs-4/packages/news/www/doc/design.adp
    • -1
    • +1
    /openacs-4/packages/news/www/doc/index.adp
Fix comment

Add flushing of user permissions as well when adding to a new group, extend comments

whitespace and comment changes

- make sure to get rid over overdue elements from statistics

- improve comments

reflow overlong lines in comments

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

white space changes

simplify code

Cleanup not more relevant comments, remove idiom meant to work in the context of a db_with_handle we are not using anymore

Reuse already existing db_list_of_ns_sets inside db_foreach and db_list_of_lists, as it uses the most native return type: the ns_set

reduce verbosity

Operate on the original list to not incur in possible memory foortprint inflation via lrange

Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used

Advantages:

- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests