• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add procdic for private function

Cookie security reform:

- fix handling of persistent logins while addressing problems of last commits

- increase usage of try/throw to be able to distinguish exceptions

- fix handling of LoginTimeout 0 in cryptographic expiration

- use [ad_conn behind_secure_proxy_p] on more occasions, where

security::secure_conn_p is used (maybe fold these together in the future)

- new private proc security::log to ease debugging of cookie management

- further improved documentation

    • -126
    • +197
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
provide ip address to be stored in acs_objects on save operation

improve comments

whitespace changes

prefer dict over Tcl array

reduce redundant lookups in auth::check_local_account_status

Use '::content::item::get_content_type' instead of the deprecated '::content::item::content_type'

Use '::content::item::get_content_type' instead of the deprecated '::content::item::content_type'

Trailing whitespace cleanup

Deprecate '::content::item::content_type', which is exactly the same proc as 'content::item::get_content_type'. Weird.

Wrap legacy and current ns_http api behavior in a proc with a common interface in a way that people with newer Naviserver can exploit e.g. ns_http run capabilities (in particular, not being forced to queue and potentially block concurrent HTTP requests)

    • -54
    • +118
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- fix serveral documentation bugs (align decumentation with implementation)

- use "throw" as well for invalid cookies (in addition to non-existent cookies)

Use ad_include_contract for this include page

Replace removed query in xotcl implementation as well

Init cache using values from db instead than cached api (fixes install from scratch)

Move remaining portable queries to tcl file

Remove obsolete partial query

Remove obsolete partial query: no reference was found in upstream code

Reduce code duplication (passes automated tests)

Streamline retrieval of mapped host nodes

Move query into tcl file

Avoid setting the whole array in the api and just return what we need

Avoid asking for an array in the api

Use api and portable idioms to reduce divergency between oracle and postgres codebase

Make test locale-aware

Replace queries with api and already available information

Fix typos in query

Move some quoting in the api

Fix typo: new relation would be added always for the latest segment

Replace stored procedures with inline queries and reduce divergency between oracle and postgres codebase