• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

remove useless semicolon

Streamline proc

Trim whitespace

- modularize web tests based on acs::test

- add new web tests for viewing and editing forums

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -0
    • +143
    /openacs-4/packages/forums/tcl/test/webtest-procs.tcl
- move new testing function "visualize_control_chars" to the namespace ::acs::test

- new testing functions

acs::test::get_form and

acs::test::xpath::get_form

to get collected form info with more ease in test cases

- bump version info to 5.10.0d7

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

Fix Test Name

Add test for the news aggregator and feed-parser

news-aggregator will reuse basic test from the feed parser

Fix subscription form error (left behind from previous commit)

no reason for casting values to integer

Use 'expr' for variable incrementing when the value is a double, as incr does not do it natively (thanks to Antonio for the pointer).

Trim whitespace

incr would return a decimal number, but test wants an integer to be returned. Restore expr and make clear that we want an integer out of it

Streamline util_sets_equal_p (passes automated test)

Add more information about typos loaded and checks passed

Fix typo + Whitespace changes

Test refactoring

Improve test documentation.

Add more common spelling errors to the 'documentation__check_typos' test case, collected from previous typo fixes in openacs.

move newly defined testing API (in OpenACS 5.10) to namespace acs::test

    • -3
    • +3
    /openacs-4/packages/forums/forums.info
    • -2
    • +2
    /openacs-4/packages/xowf/www/index.vuh
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
handle authorizations with no auth_sync_process defined without raising an error in the error.log

Fix typo, trim whitespace

Trim whitespaces

Reduce test verbosity

Add new test case 'documentation__check_typos', which checks for spelling errors in the proc documentation.

The test uses a file containing common spelling errors (doc-check-procs-common-typos.txt), based in the one

provided by Debian's lintian, which can be found here: https://github.com/Debian/lintian/tree/master/data/spelling

The test can take some time, depending on the amount of packages and how powerful the machine is.

Fix typo

Replace array idioms with dict idioms

    • -20
    • +25
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Replace array idioms with dict idioms

    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Replace array idioms with dict idioms

    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl