• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
align comment to implementation; be more explicit on optional/default values

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Whitespace changes

    • -5
    • +5
    /openacs-4/packages/chat/www/search-2.tcl
Avoid unnecesary existence checks.

    • -4
    • +2
    /openacs-4/packages/chat/www/search-2.tcl
Remove duplication and use more api

This code could not work on oracle... not sure if this was considered, or people just assumed fts was a Postgres-only thing

Whitespace cleanup

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Use api to remove difference between oracle and postgres code and replace array with dict idioms

Remove leftover xql files

Use api to remove difference between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Avoid two times the same query just because we might filter by forum

Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

Remove leftover sql and unused variables

Whitespace changes

new feature: offer swa the ability to view compiled template

Reduce divergency between oracle and postgres codebase and remove redundant statements

Remove leftover statement

remove empty, unused, privated function acs_reference_get_db_structure

whitespace changes

remove unused private function acs_object_type::acs_object_instance_of

fix broken API function acs_object_type::get_table_name (broken since 13 years) and use API instead of direct SQL queries

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
remove outdated file, maintained version of the code is in the function apm_build_repository

Whitespace cleanup

Fix singular/plural phrasing

Fix typos