• last updated 11 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

Fix typo (thanks to Thomas Renner)

reduce redirects

    • -3
    • +3
    • -1
    • +1
Fix comment

Add flushing of user permissions as well when adding to a new group, extend comments

whitespace and comment changes

- make sure to get rid over overdue elements from statistics

- improve comments

reflow overlong lines in comments

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

white space changes

simplify code

Cleanup not more relevant comments, remove idiom meant to work in the context of a db_with_handle we are not using anymore

Reuse already existing db_list_of_ns_sets inside db_foreach and db_list_of_lists, as it uses the most native return type: the ns_set

reduce verbosity

Operate on the original list to not incur in possible memory foortprint inflation via lrange

Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used


- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests

Reduce code duplication

Introduce -with_headers flag in db_list_of_lists so names of returned column values can be returned as well as the first list in the result

Reduce code duplication (passes automated tests)

Refactoring of 'folder-zip-add'

return empty body in 304 replies

Fix folder creation in 'folder-zip-add'

add missing script abort

new parameter: use_fallback_page_in_system_locale

When this parameter is set, use the page in the system locale as fallback rather than offering a link for creation of a page in that locale, when the page in the requested locale does not exist.

Bump version to 5.10.0d21

    • -2
    • +3
    • -3
    • +16
improve security of ad_forms by binding request to a user

fix bracket in last commit

use usual idioms, white space changes

Whitespace changes

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.