• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used

Advantages:

- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests

Reduce code duplication

Introduce -with_headers flag in db_list_of_lists so names of returned column values can be returned as well as the first list in the result

Reduce code duplication (passes automated tests)

Refactoring of 'folder-zip-add'

return empty body in 304 replies

Fix folder creation in 'folder-zip-add'

add missing script abort

new parameter: use_fallback_page_in_system_locale

When this parameter is set, use the page in the system locale as fallback rather than offering a link for creation of a page in that locale, when the page in the requested locale does not exist.

Bump version to 5.10.0d21

    • -2
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -3
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
improve security of ad_forms by binding request to a user

fix bracket in last commit

use usual idioms, white space changes

Whitespace changes

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Remove unwanted change

Reflect changes in util__table_column_exists in tcl api and make xotcl-core dependant on latest acs-kernel

Drop function first, as name of parameters changed

Don't rely on the delete trigger being named consistently on different installations

Add again double quotes in the add constraint as well

Add double quotes in case constraints were defined using e.g. $ in the old days

Use generic acs_object__delete, so also eventual relations are deleted

    • -0
    • +17
    /openacs-4/packages/faq/www/admin/faq-delete-oracle.xql
    • -0
    • +17
    /openacs-4/packages/faq/www/admin/q_and_a-delete-oracle.xql
Actually delete from the acs_object, or it will stay around

ad_return_url: change default value for default_url to "."

this is not terribly important, but probably a better approximation

fix for issue #3379

switch from security::nonce_token to ::security::csp::nonce and update comments

switch from security::nonce_token to ::security::csp::nonce

The latter one is available since more then two years in OpenACS.

xo::broadcast: allow to send messages to threads seleced via pattern

address global variable __csrf_token directly

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
terminate message key properly